[release-4.7] Bug 1942027: Fix RBAC check when creating a resource #8448

openshift-cherrypick-robot · 2021-03-23T13:16:09Z

This is an automated cherry-pick of #8440

/assign spadgett

Don't perform an update check in the YAML editor when creating a new resource.

openshift-ci-robot · 2021-03-23T13:16:19Z

@openshift-cherrypick-robot: Bugzilla bug 1824911 has been cloned as Bugzilla bug 1942027. Retitling PR to link against new bug.
/retitle [release-4.7] Bug 1942027: Fix RBAC check when creating a resource

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2021-03-23T13:16:36Z

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1942027, which is invalid:

expected dependent Bugzilla bug 1824911 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is MODIFIED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

spadgett · 2021-03-23T13:17:15Z

/bugzilla refresh

openshift-ci-robot · 2021-03-23T13:17:19Z

@spadgett: This pull request references Bugzilla bug 1942027, which is invalid:

expected dependent Bugzilla bug 1824911 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is MODIFIED instead
expected dependent Bugzilla bug 1824911 to target a release in 4.8.0, but it targets "4.7.z" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

spadgett

/lgtm

spadgett · 2021-03-23T14:21:42Z

/bugzilla refresh

openshift-ci-robot · 2021-03-23T14:21:46Z

@spadgett: This pull request references Bugzilla bug 1942027, which is invalid:

expected dependent Bugzilla bug 1824911 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is MODIFIED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-03-24T01:00:24Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2021-03-24T01:00:28Z

@openshift-bot: This pull request references Bugzilla bug 1942027, which is invalid:

expected dependent Bugzilla bug 1824911 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-03-25T01:00:56Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2021-03-25T01:01:00Z

@openshift-bot: This pull request references Bugzilla bug 1942027, which is invalid:

expected dependent Bugzilla bug 1824911 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-03-26T01:00:17Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2021-03-26T01:00:21Z

@openshift-bot: This pull request references Bugzilla bug 1942027, which is invalid:

expected dependent Bugzilla bug 1824911 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-03-27T01:00:17Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2021-03-27T01:00:20Z

@openshift-bot: This pull request references Bugzilla bug 1942027, which is invalid:

expected dependent Bugzilla bug 1824911 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-03-28T01:01:03Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2021-03-28T01:01:07Z

@openshift-bot: This pull request references Bugzilla bug 1942027, which is invalid:

expected dependent Bugzilla bug 1824911 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-04-11T01:00:29Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2021-04-11T01:00:33Z

@openshift-bot: This pull request references Bugzilla bug 1942027, which is invalid:

expected dependent Bugzilla bug 1824911 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-04-12T01:00:25Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2021-04-12T01:00:44Z

@openshift-bot: This pull request references Bugzilla bug 1942027, which is invalid:

expected dependent Bugzilla bug 1824911 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-04-13T01:00:58Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2021-04-13T01:01:02Z

@openshift-bot: This pull request references Bugzilla bug 1942027, which is invalid:

expected dependent Bugzilla bug 1824911 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-04-14T01:01:04Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2021-04-14T01:01:13Z

@openshift-bot: This pull request references Bugzilla bug 1942027, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.7.z) matches configured target release for branch (4.7.z)
bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
dependent bug Bugzilla bug 1824911 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
dependent Bugzilla bug 1824911 targets the "4.8.0" release, which is one of the valid target releases: 4.8.0
bug has dependents

Requesting review from QA contact:
/cc @yapei

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

yanpzhan · 2021-04-14T04:39:10Z

Tested against the pr, now after arrant normal user "system:persistent-volume-provisioner", the pv page could show up, and user could create/delete pv successfully, and could not edit pv as designed.
/lgtm
/label qe-approved

mfojtik · 2021-04-14T14:30:54Z

[patch-manager] ⌛ This pull request was not picked by the patch manager for the current z-stream window and have to wait for the next window.

Score: 0.20
Reason: maximum total for this z-stream is 10

NOTE: This message was automatically generated, if you have questions please ask on #forum-release

yanpzhan · 2021-04-20T01:35:30Z

/lgtm

yanpzhan · 2021-04-20T03:31:49Z

/bugzilla refresh

openshift-ci-robot · 2021-04-20T03:31:53Z

@yanpzhan: This pull request references Bugzilla bug 1942027, which is valid.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.7.z) matches configured target release for branch (4.7.z)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
dependent bug Bugzilla bug 1824911 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
dependent Bugzilla bug 1824911 targets the "4.8.0" release, which is one of the valid target releases: 4.8.0
bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (yanpzhan@redhat.com), skipping review request.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

yanpzhan · 2021-04-20T03:32:47Z

/lgtm

yanpzhan · 2021-04-20T03:59:47Z

/bugzilla cc-qa

openshift-ci-robot · 2021-04-20T03:59:51Z

@yanpzhan: This pull request references Bugzilla bug 1942027, which is valid.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.7.z) matches configured target release for branch (4.7.z)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
dependent bug Bugzilla bug 1824911 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
dependent Bugzilla bug 1824911 targets the "4.8.0" release, which is one of the valid target releases: 4.8.0
bug has dependents

Requesting review from QA contact:
/cc @yanpzhan

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

yanpzhan · 2021-04-20T04:03:14Z

/lgtm

openshift-ci-robot · 2021-04-29T23:53:56Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-cherrypick-robot, spadgett, yanpzhan, zherman0

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~frontend/OWNERS~~ [spadgett]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-bot · 2021-05-07T03:43:51Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-ci · 2021-05-07T05:25:53Z

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged:

openshift/console#8448

Bugzilla bug 1942027 has been moved to the MODIFIED state.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Bug 1824911: Fix RBAC check when creating a resource

c9afec2

Don't perform an update check in the YAML editor when creating a new resource.

openshift-cherrypick-robot mentioned this pull request Mar 23, 2021

Bug 1824911: Fix RBAC check when creating a resource #8440

Merged

openshift-ci-robot assigned spadgett Mar 23, 2021

openshift-ci-robot added the component/core Related to console core functionality label Mar 23, 2021

openshift-ci-robot requested review from jeff-phillips-18 and kyoto March 23, 2021 13:16

openshift-ci-robot changed the title ~~[release-4.7] Bug 1824911: Fix RBAC check when creating a resource~~ [release-4.7] Bug 1942027: Fix RBAC check when creating a resource Mar 23, 2021

openshift-ci-robot added bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Mar 23, 2021

spadgett approved these changes Mar 23, 2021

View reviewed changes

openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 23, 2021

spadgett added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. and removed bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. labels Mar 23, 2021

openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Apr 14, 2021

openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Apr 14, 2021

openshift-ci-robot requested a review from yapei April 14, 2021 01:01

openshift-ci-robot added the qe-approved Signifies that QE has signed off on this PR label Apr 14, 2021

openshift-ci-robot assigned yanpzhan Apr 14, 2021

openshift-ci-robot requested a review from yanpzhan April 20, 2021 03:59

zherman0 approved these changes Apr 29, 2021

View reviewed changes

knobunc added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label May 6, 2021

openshift-merge-robot merged commit 110b70f into openshift:release-4.7 May 7, 2021

spadgett added this to the v4.7.z milestone May 10, 2021

[release-4.7] Bug 1942027: Fix RBAC check when creating a resource #8448

[release-4.7] Bug 1942027: Fix RBAC check when creating a resource #8448

Conversation

openshift-cherrypick-robot commented Mar 23, 2021

openshift-ci-robot commented Mar 23, 2021

openshift-ci-robot commented Mar 23, 2021

spadgett commented Mar 23, 2021

openshift-ci-robot commented Mar 23, 2021

spadgett left a comment

Choose a reason for hiding this comment

spadgett commented Mar 23, 2021

openshift-ci-robot commented Mar 23, 2021

openshift-bot commented Mar 24, 2021

openshift-ci-robot commented Mar 24, 2021

openshift-bot commented Mar 25, 2021

openshift-ci-robot commented Mar 25, 2021

openshift-bot commented Mar 26, 2021

openshift-ci-robot commented Mar 26, 2021

openshift-bot commented Mar 27, 2021

openshift-ci-robot commented Mar 27, 2021

openshift-bot commented Mar 28, 2021

openshift-ci-robot commented Mar 28, 2021

openshift-bot commented Apr 11, 2021

openshift-ci-robot commented Apr 11, 2021

openshift-bot commented Apr 12, 2021

openshift-ci-robot commented Apr 12, 2021

openshift-bot commented Apr 13, 2021

openshift-ci-robot commented Apr 13, 2021

openshift-bot commented Apr 14, 2021

openshift-ci-robot commented Apr 14, 2021

yanpzhan commented Apr 14, 2021

mfojtik commented Apr 14, 2021

yanpzhan commented Apr 20, 2021

yanpzhan commented Apr 20, 2021

openshift-ci-robot commented Apr 20, 2021

yanpzhan commented Apr 20, 2021

yanpzhan commented Apr 20, 2021

openshift-ci-robot commented Apr 20, 2021

yanpzhan commented Apr 20, 2021

openshift-ci-robot commented Apr 29, 2021

openshift-bot commented May 7, 2021

openshift-ci bot commented May 7, 2021