Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1927423: Monitoring: Add warning to list pages when silences cannot be loaded #8461

Merged
merged 1 commit into from Mar 25, 2021
Merged

Bug 1927423: Monitoring: Add warning to list pages when silences cannot be loaded #8461

merged 1 commit into from Mar 25, 2021

Conversation

kyoto
Copy link
Member

@kyoto kyoto commented Mar 25, 2021

Adds a warning message to the alerts list and alerting rules list pages
when the silences cannot be loaded from Alertmanager.

screenshot

FYI @cshinn

@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. label Mar 25, 2021
@openshift-ci-robot
Copy link
Contributor

@kyoto: This pull request references Bugzilla bug 1927423, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.8.0) matches configured target release for branch (4.8.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @lihongyan1

In response to this:

Bug 1927423: Monitoring: Add warning to list pages when silences cannot be loaded

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Mar 25, 2021
@openshift-ci-robot openshift-ci-robot added component/monitoring Related to monitoring approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 25, 2021
@kyoto
Monitoring: Add warning to list pages when silences cannot be loaded
b217576 
Adds a warning message to the alerts list and alerting rules list pages
when the silences cannot be loaded from Alertmanager.
@kyoto kyoto force-pushed the monitoring-silences-load-fail-warning branch from 5e27066 to b217576 Compare March 25, 2021 04:07
@openshift-ci-robot openshift-ci-robot added the kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated label Mar 25, 2021
@kyoto
Copy link
Member Author

kyoto commented Mar 25, 2021

/retest

spadgett
spadgett approved these changes Mar 25, 2021
View reviewed changes
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kyoto, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 25, 2021
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 0357aa1 into openshift:master Mar 25, 2021
@openshift-ci-robot
Copy link
Contributor

@kyoto: All pull requests linked via external trackers have merged:

Bugzilla bug 1927423 has been moved to the MODIFIED state.

In response to this:

Bug 1927423: Monitoring: Add warning to list pages when silences cannot be loaded

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett spadgett added this to the v4.8 milestone Mar 25, 2021
@kyoto kyoto deleted the monitoring-silences-load-fail-warning branch March 26, 2021 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spadgett spadgett spadgett approved these changes

@lihongyan1 lihongyan1 Awaiting requested review from lihongyan1

@TheRealJon TheRealJon Awaiting requested review from TheRealJon

Assignees

@spadgett spadgett

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/core Related to console core functionality component/monitoring Related to monitoring kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
v4.8
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@kyoto @openshift-ci-robot @openshift-bot @spadgett @openshift-merge-robot