Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update prow deployment script #8608

Merged
merged 1 commit into from May 11, 2021
Merged

Update prow deployment script #8608

merged 1 commit into from May 11, 2021

Conversation

pcbailey
Copy link
Contributor

@pcbailey pcbailey commented Apr 11, 2021 •
edited

This script will replace the current installation of KubeVirt on prow with an HCO installation. It will also add the Red Hat support annotations to Red Hat supported templates.

Depends on #8654

@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 11, 2021
@openshift-ci-robot openshift-ci-robot added component/kubevirt Related to kubevirt-plugin approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 11, 2021
@pcbailey pcbailey force-pushed the update-prow-deployment-script branch from 2b98c5f to d2bc0b5 Compare April 11, 2021 02:07
@yaacov yaacov mentioned this pull request Apr 11, 2021
Merged
@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 12, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 12, 2021

@pcbailey: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pcbailey pcbailey force-pushed the update-prow-deployment-script branch from d2bc0b5 to 8509513 Compare April 13, 2021 13:37
yaacov
yaacov reviewed Apr 13, 2021
View reviewed changes
frontend/packages/kubevirt-plugin/integration-tests/deploy-kubevirt-gating.sh
VIRTCTL_DOWNLOAD_URL="https://github.com/kubevirt/kubevirt/releases/download/${KUBEVIRT_VERSION}/virtctl-${KUBEVIRT_VERSION}"
VIRTCTL_X86_64="${VIRTCTL_DOWNLOAD_URL}-linux-x86_64"
VIRTCTL_AMD64="${VIRTCTL_DOWNLOAD_URL}-linux-amd64"
HCO_VERSION="master"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we use some version that works for us, o/w we may get stuck with broken master (now called main) versions ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The latest release doesn't install the common templates. I think we should leave it at master/main until they release again.

@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 13, 2021
@pcbailey pcbailey force-pushed the update-prow-deployment-script branch from 8509513 to ab2c17e Compare April 14, 2021 12:24
@pcbailey pcbailey mentioned this pull request Apr 14, 2021
Merged
@pcbailey pcbailey force-pushed the update-prow-deployment-script branch 2 times, most recently from 25b7d9c to 6eb429c Compare April 17, 2021 00:31
@pcbailey pcbailey changed the title WIP: Update prow deployment script Update prow deployment script Apr 18, 2021
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 18, 2021
@pcbailey
Copy link
Contributor Author

/test kubevirt-plugin

1 similar comment
@pcbailey
Copy link
Contributor Author

/test kubevirt-plugin

yaacov
yaacov reviewed Apr 19, 2021
View reviewed changes
frontend/packages/kubevirt-plugin/integration-tests/deploy-kubevirt-gating.sh

VIRTCTL_DOWNLOAD_URL="https://github.com/kubevirt/kubevirt/releases/download/${KUBEVIRT_VERSION}/virtctl-${KUBEVIRT_VERSION}"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you remove the VIRTCTL_DOWNLOAD_URL how does it know where to get the virtctl command line from ?

@pcbailey pcbailey force-pushed the update-prow-deployment-script branch 2 times, most recently from 22a6a17 to 417b5b7 Compare April 19, 2021 14:58
@pcbailey
Copy link
Contributor Author

/test kubevirt-plugin

@pcbailey pcbailey force-pushed the update-prow-deployment-script branch 2 times, most recently from 6b1b784 to 708553b Compare April 26, 2021 11:42
@yaacov
Copy link
Member

yaacov commented Apr 26, 2021

/retest

yaacov
yaacov reviewed Apr 26, 2021
View reviewed changes
frontend/packages/kubevirt-plugin/integration-tests/deploy-kubevirt-gating.sh Outdated
data:
feature-gates: "DataVolumes,SRIOV,LiveMigration,CPUManager,CPUNodeDiscovery,Sidecar,Snapshot"
EOF
oc get -n openshift template windows10-desktop-large
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
oc get -n openshift template windows10-desktop-large
output=$(oc get -n openshift template windows10-desktop-large 2>/dev/null)

@yaacov
Copy link
Member

yaacov commented Apr 29, 2021

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 29, 2021
@yaacov
Copy link
Member

yaacov commented Apr 29, 2021

/lgtm cancel
/retest

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Apr 29, 2021
@pcbailey pcbailey force-pushed the update-prow-deployment-script branch 3 times, most recently from 8f9cc75 to 7df526b Compare May 2, 2021 18:34
yaacov
yaacov reviewed May 3, 2021
View reviewed changes
frontend/packages/kubevirt-plugin/integration-tests/deploy-kubevirt-gating.sh Outdated
mkdir virtctl

wget ${VIRTCTL_AMD64} -O virtctl/virtctl || wget ${VIRTCTL_X86_64} -O virtctl/virtctl
[[ ! -f "virtctl/virtctl" ]] && echo "ERROR: virtctl binary is unavailable for download" && exit 1

chmod +x virtctl/virtctl

export PATH="${PATH}:$(pwd)/virtctl"
export PATH="${PATH}:$(pwd)/virtctl/virtctl"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm, are you sure ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

During my testing, it didn't recognize it without adding that. I saw the error that virtctl couldn't be found, though. I don't know why adding something to the path would be different in CI vs other methods, but I'll change it back. I found it odd that I had to change it in the first place since we've been using this in the current deploy script for some time now.

@yaacov
Copy link
Member

yaacov commented May 3, 2021

@pcbailey hi, the test that fails tests for "redhat support" label on a template and expect it to be missing ... so the install script worked correctly, now we need to understand why the test is failing when we add redhat support (test is wrong ? we have a bug the test caught ? ... )

@pcbailey
Copy link
Contributor Author

pcbailey commented May 3, 2021

@yaacov I'll look into it. I'm assuming the test is currently written with the expectation that the support label will not be there since our CI installation currently doesn't add the support annotations.

@yaacov
Copy link
Member

yaacov commented May 3, 2021

@yaacov I'll look into it. I'm assuming the test is currently written with the expectation that the support label will not be there since our CI installation currently doesn't add the support annotations.

@gouyang hi, do you know if we should test with "templates support annotations" or without them (e.g. downstream or upstream) ?

@pcbailey pcbailey force-pushed the update-prow-deployment-script branch from 9e740f4 to fd4bc4f Compare May 3, 2021 14:21
@pcbailey pcbailey force-pushed the update-prow-deployment-script branch from fd4bc4f to fb2a97b Compare May 3, 2021 19:44
@pcbailey
Copy link
Contributor Author

pcbailey commented May 4, 2021

/test kubevirt-plugin

@yaacov
Copy link
Member

yaacov commented May 4, 2021

/lgtm
🎉

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 4, 2021
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pcbailey, yaacov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pcbailey
Copy link
Contributor Author

pcbailey commented May 4, 2021

/test kubevirt-plugin

@pcbailey
Copy link
Contributor Author

/test ci/prow/analyze

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 10, 2021

@pcbailey: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

  • /test analyze
  • /test backend
  • /test ceph-storage-plugin
  • /test e2e-gcp-console
  • /test frontend
  • /test images
  • /test kubevirt-plugin

Use /test all to run the following jobs:

  • pull-ci-openshift-console-master-analyze
  • pull-ci-openshift-console-master-backend
  • pull-ci-openshift-console-master-e2e-gcp-console
  • pull-ci-openshift-console-master-frontend
  • pull-ci-openshift-console-master-images
  • pull-ci-openshift-console-master-kubevirt-plugin

In response to this:

/test ci/prow/analyze

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pcbailey
Copy link
Contributor Author

/test analyze

@pcbailey
Copy link
Contributor Author

/test kubevirt-plugin

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 0013306 into openshift:master May 11, 2021
@spadgett spadgett added this to the v4.8 milestone May 13, 2021
@pcbailey pcbailey deleted the update-prow-deployment-script branch October 26, 2022 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaacov yaacov yaacov left review comments

@mareklibra mareklibra Awaiting requested review from mareklibra

Assignees

@yaacov yaacov

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/kubevirt Related to kubevirt-plugin lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
v4.8
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@pcbailey @yaacov @openshift-ci-robot @openshift-bot @spadgett @openshift-merge-robot