Support Embedded Task/Pipeline/Pipeline Resources #8630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
kind/i18n
andrewballantyne
force-pushed
the
support-embedded-resources
branch
from
052bd69
to
97d95e8
Compare
|
Verified locally, works fine |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andrewballantyne, bgliwa01, karthikjeeyar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest Please review the full test history for this PR and help us cut down flakes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes:
https://issues.redhat.com/browse/ODC-5272
Analysis / Root cause:
Embedded Specs were widely just ignored and hidden when they happened. There are three we focused on and hide, they are:
Solution Description:
Support them in a basic fashion, instead of hiding them, show an "Embedded ..." text.
Screen shots / Gifs for design review:
@openshift/team-devconsole-ux
Embedded Pipeline Resource and Stand-alone Pipeline resource:
All Embedded Tasks:
Mixture of Embedded Tasks and Stand-alone Task resources:
Both Embedded Pipeline and Embedded Pipeline Resource:
Slight modification to existing Stand-alone Pipeline Resources to showcase the type (names can be anything, but our generated names have the type, like below):
Unit test coverage report:
Coming Soon...
Test setup:
Setup Pipelines with various embedded Tasks
Setup Pipeline Runs with various embedded Pipeline Resources & embedded Pipeline
Some example resource files:
Browser conformance:
cc @bgliwa01 @karthikjeeyar