Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1942858: [RFE]Confusing detach volume UX #8652

Merged
merged 1 commit into from
Apr 14, 2021
Merged

Bug 1942858: [RFE]Confusing detach volume UX #8652

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 3 additions & 2 deletions frontend/packages/kubevirt-plugin/locales/en/kubevirt-plugin.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -409,10 +409,11 @@
"new VM name": "new VM name",
"Start virtual machine on clone": "Start virtual machine on clone",
"Configuration": "Configuration",
"Delete {{diskName}} disk": "Delete {{diskName}} disk",
"Are you sure you want to delete <1>{{diskName}}</1> disk?": "Are you sure you want to delete <1>{{diskName}}</1> disk?",
"Detach {{diskName}} disk": "Detach {{diskName}} disk",
"Are you sure you want to detach <1>{{diskName}}</1> disk?": "Are you sure you want to detach <1>{{diskName}}</1> disk?",
"Delete {{ownedResourceName}} {{ownedResourceLabel}} and PVC": "Delete {{ownedResourceName}} {{ownedResourceLabel}} and PVC",
"Delete {{ownedResourceName}} {{ownedResourceLabel}}": "Delete {{ownedResourceName}} {{ownedResourceLabel}}",
"Detach": "Detach",
"Delete {{nicName}} NIC": "Delete {{nicName}} NIC",
"Are you sure you want to delete <1>{{nicName}}</1> network interface?": "Are you sure you want to delete <1>{{nicName}}</1> network interface?",
"Delete source": "Delete source",
Expand Down
6 changes: 3 additions & 3 deletions ...nd/packages/kubevirt-plugin/src/components/modals/delete-disk-modal/delete-disk-modal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,11 +71,11 @@ export const DeleteDiskModal = withHandlePromise((props: DeleteDiskModalProps) =
<form onSubmit={submit} className="modal-content">
<ModalTitle>
<YellowExclamationTriangleIcon className="co-icon-space-r" />{' '}
{t('kubevirt-plugin~Delete {{diskName}} disk', { diskName })}
{t('kubevirt-plugin~Detach {{diskName}} disk', { diskName })}
</ModalTitle>
<ModalBody>
<Trans t={t} ns="kubevirt-plugin">
Are you sure you want to delete <strong className="co-break-word">{{ diskName }}</strong>{' '}
Are you sure you want to detach <strong className="co-break-word">{{ diskName }}</strong>{' '}
disk?
</Trans>
{ownedResource && (
Expand Down Expand Up @@ -103,7 +103,7 @@ export const DeleteDiskModal = withHandlePromise((props: DeleteDiskModalProps) =
errorMessage={errorMessage}
submitDisabled={isInProgress}
inProgress={isInProgress}
submitText={t('kubevirt-plugin~Delete')}
submitText={t('kubevirt-plugin~Detach')}
submitDanger
cancel={cancel}
/>
Expand Down