New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adds devfile provider for dev catalog #8812
adds devfile provider for dev catalog #8812
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: invincibleJai The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cc @rottencandy |
/hold adding hold as depends on #8794 |
daf3d77
to
5337915
Compare
This looks good to me! |
}; | ||
coFetchJSON | ||
.put('/api/devfile/samples', payload) | ||
.then(setDevfileSamples) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should check if component is still mounted before setting state.
5337915
to
304c8ab
Compare
Hi @invincibleJai. One question. On the Developer Catalog there is a (?) next to Type. This is a popover with a definition of all the types. Do you know if this issue includes adding Devfiles to this? I did not see it in the Epic. |
yes @beaumorley, have handled it as part of the same PR. If you think there is a need to change the text for devFile LMK or can log a ticket to update it. |
086fff2
to
6ae3953
Compare
We had a discussion on this scenario in the devfile cabal. Please connect with @rohitkrai03. As the scenario for changing the git url and using the sample as a stack wasn't considered by the devfile team. |
9d5de20
to
0dc238a
Compare
0dc238a
to
e40c810
Compare
e56a5da
to
32e52a0
Compare
32e52a0
to
d442121
Compare
/hold cancel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Tested the PR locally. Everything works as expected.
GIF -
Screen.Recording.2021-05-12.at.6.17.54.PM.mov
/label qe-approved
on behalf of devconsole QE team after QE testing the PR as agreed upon.
/label px-approved
added on behalf of px as agreed upon.
/label docs-approved
added on behalf of docs team as the epic has doc-ack label. The feature is dev preview and marked with no-docs label.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: invincibleJai, rohitkrai03 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fixes:
https://issues.redhat.com/browse/ODC-5729
Analysis / Root cause:
Solution Description:
adds devfile provider for dev catalog so that user can see type
devfiles
in the catalog and create oneScreen shots / Gifs for design review:
@openshift/team-devconsole-ux @lwrigh
Review commit: 9c1b913
Depends on: #8794
Browser conformance: