Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds devfile provider for dev catalog #8812

Merged

Conversation

invincibleJai
Copy link
Member

Fixes:
https://issues.redhat.com/browse/ODC-5729

Analysis / Root cause:

Solution Description:
adds devfile provider for dev catalog so that user can see type devfiles in the catalog and create one

Screen shots / Gifs for design review:
@openshift/team-devconsole-ux @lwrigh

image

image

image

image

Review commit: 9c1b913

Depends on: #8794

Browser conformance:

  • Chrome
  • Firefox
  • Safari
  • Edge

@openshift-ci-robot openshift-ci-robot added the component/backend Related to backend label Apr 28, 2021
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: invincibleJai
To complete the pull request process, please assign bparees after the PR has been reviewed.
You can assign the PR to them by writing /assign @bparees in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added component/dev-console Related to dev-console kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated labels Apr 28, 2021
@invincibleJai
Copy link
Member Author

/cc @rottencandy
/assign @rohitkrai03

@invincibleJai
Copy link
Member Author

/hold

adding hold as depends on #8794

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 28, 2021
@invincibleJai invincibleJai force-pushed the pr-8794-5729-2 branch 3 times, most recently from daf3d77 to 5337915 Compare April 28, 2021 11:02
@lwrigh
Copy link

lwrigh commented Apr 28, 2021

This looks good to me!

};
coFetchJSON
.put('/api/devfile/samples', payload)
.then(setDevfileSamples)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should check if component is still mounted before setting state.

@beaumorley
Copy link

Hi @invincibleJai. One question. On the Developer Catalog there is a (?) next to Type. This is a popover with a definition of all the types. Do you know if this issue includes adding Devfiles to this? I did not see it in the Epic.

@invincibleJai
Copy link
Member Author

Hi @invincibleJai. One question. On the Developer Catalog there is a (?) next to Type. This is a popover with a definition of all the types. Do you know if this issue includes adding Devfiles to this? I did not see it in the Epic.

yes @beaumorley, have handled it as part of the same PR. If you think there is a need to change the text for devFile LMK or can log a ticket to update it.

image

@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 29, 2021
@invincibleJai invincibleJai force-pushed the pr-8794-5729-2 branch 2 times, most recently from 086fff2 to 6ae3953 Compare April 29, 2021 10:28
@openshift-ci openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 29, 2021
@christianvogt
Copy link
Contributor

We had a discussion on this scenario in the devfile cabal. Please connect with @rohitkrai03. As the scenario for changing the git url and using the sample as a stack wasn't considered by the devfile team.

@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 4, 2021
@invincibleJai invincibleJai force-pushed the pr-8794-5729-2 branch 3 times, most recently from 9d5de20 to 0dc238a Compare May 11, 2021 08:00
@openshift-ci openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 11, 2021
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 12, 2021
@invincibleJai invincibleJai force-pushed the pr-8794-5729-2 branch 3 times, most recently from e56a5da to 32e52a0 Compare May 12, 2021 12:30
@rohitkrai03
Copy link
Contributor

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 12, 2021
Copy link
Contributor

@rohitkrai03 rohitkrai03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Tested the PR locally. Everything works as expected.

GIF -

Screen.Recording.2021-05-12.at.6.17.54.PM.mov

/label qe-approved
on behalf of devconsole QE team after QE testing the PR as agreed upon.

/label px-approved
added on behalf of px as agreed upon.

/label docs-approved
added on behalf of docs team as the epic has doc-ack label. The feature is dev preview and marked with no-docs label.

@openshift-ci openshift-ci bot added qe-approved Signifies that QE has signed off on this PR px-approved Signifies that Product Support has signed off on this PR docs-approved Signifies that Docs has signed off on this PR lgtm Indicates that a PR is ready to be merged. labels May 12, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 12, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: invincibleJai, rohitkrai03

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 794b592 into openshift:master May 13, 2021
@spadgett spadgett added this to the v4.8 milestone May 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/backend Related to backend component/dev-console Related to dev-console component/helm Related to helm-plugin docs-approved Signifies that Docs has signed off on this PR kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants