Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(OCS dashboard): s/namesapce/namespace/ prometheus query typos #8863

Merged

Conversation

tumido
Copy link
Contributor

@tumido tumido commented May 6, 2021

Digging through the OCS queries I've noticed a typo here - namesapce is a nonsense. Neither of those queries has such label. I think this should have been a namespace which is a valid label. On the other hand I'm not sure how much is this on() property here even relevant or important, because the queries were left like this for long long time.

Signed-off-by: Tomas Coufal <tcoufal@redhat.com>
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: tumido
To complete the pull request process, please assign bipuladh after the PR has been reviewed.
You can assign the PR to them by writing /assign @bipuladh in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added component/ceph Related to ceph-storage-plugin needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 6, 2021
@openshift-ci-robot
Copy link
Contributor

Hi @tumido. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett
Copy link
Member

spadgett commented May 6, 2021

/ok-to-test
/cc @cloudbehl @bipuladh

@openshift-ci-robot openshift-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 6, 2021
@afreen23
Copy link
Contributor

@anmolsachan PTAL
I think we recently updated some of them as the bug fix.
Thanks

@afreen23
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 10, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 10, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afreen23, anmolsachan, tumido

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 10, 2021
@openshift-merge-robot openshift-merge-robot merged commit 56bb0db into openshift:master Jun 10, 2021
@spadgett spadgett added this to the v4.8 milestone Jun 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/ceph Related to ceph-storage-plugin lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants