Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add helm config export in oc-environment script #8910

Merged

Conversation

rohitkrai03
Copy link
Contributor

Fixes: https://issues.redhat.com/browse/ODC-5831

Analysis / Root cause: Helm install form doesn't work correctly in a local setup when helm repo is setup in Helm CLI

Solution Description: Add a Helm repository config export to oc-environment.sh script for local development. Adding this export bypasses the repositories added in Helm CLI and doesn't interfere with the backend API.

Screen shots / Gifs for design review: No UI change.

Browser conformance:

  • Chrome
  • Firefox
  • Safari
  • Edge

@rohitkrai03
Copy link
Contributor Author

/assign @christianvogt

@invincibleJai
Copy link
Member

/lgtm

verified the changes in master it doesn't work and works fine with the PR

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 17, 2021
@jerolimov
Copy link
Member

👍 Used this export since a long time locally ;)

@christianvogt
Copy link
Contributor

Dev env script only change.

/kind bug
/approve

@openshift-ci openshift-ci bot added the kind/bug Categorizes issue or PR as related to a bug. label May 21, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 21, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christianvogt, invincibleJai, rohitkrai03

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 21, 2021
@openshift-merge-robot openshift-merge-robot merged commit d6aa616 into openshift:master May 21, 2021
@spadgett spadgett added this to the v4.8 milestone Jun 8, 2021
@rohitkrai03 rohitkrai03 deleted the helm-local-setup-fix branch July 24, 2021 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants