Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update table classes for kube-virt, ceph-storage, bare-metal and network attachment #9053

Merged
merged 1 commit into from Jun 23, 2021
Merged

Update table classes for kube-virt, ceph-storage, bare-metal and network attachment #9053

merged 1 commit into from Jun 23, 2021

Conversation

abhinandan13jan
Copy link
Contributor

@abhinandan13jan abhinandan13jan commented May 26, 2021 •
edited

Addresses

https://issues.redhat.com/browse/ODC-5816

Screenshots

Ceph
ceph

Kubevirt

vm-layout
vm-nic
vm-wizard

Tests

None change

Broswer conformance

Chrome

@openshift-ci openshift-ci bot added the component/ceph Related to ceph-storage-plugin label May 26, 2021
@openshift-ci openshift-ci bot requested review from afreen23 and honza May 26, 2021 12:53
@openshift-ci openshift-ci bot added component/kubevirt Related to kubevirt-plugin component/metal3 Related to metal3-plugin component/network-attachment-definition Related to network-attachment-definition labels May 26, 2021
@abhinandan13jan abhinandan13jan force-pushed the tableclass2 branch 2 times, most recently from b466685 to ad00abf Compare May 27, 2021 14:39
@abhinandan13jan
Copy link
Contributor Author

/test kubevirt-plugin

afreen23
afreen23 approved these changes May 29, 2021
View reviewed changes
Copy link
Contributor

@afreen23 afreen23 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved ceph chnages. Thanks for the fix!

@abhinandan13jan
Copy link
Contributor Author

/test kubevirt-plugin

@andrewballantyne
Copy link
Contributor

/retest

@glekner
Copy link
Contributor

glekner commented Jun 17, 2021

missing some kubevirt tables
image

@abhinandan13jan
Copy link
Contributor Author

missing some kubevirt tables
image

Hi @glekner , I checked the files and all are updated and most have no associated bootstrap class for table, so there is no need for a change. This PR targets to update Bootstrap classes used in tables.

  • networking-tab.tsx -- imports nicTableColumnClasses from another file
  • vm-wizard-nic-row -- columnClasses is a prop, cannot find any bootstrap class
  • vm-wizard-storage -- same as abve
  • affinity-modal -- borrows columnclass from helper file which is updated
  • disk-row -- columnClass is a prop. no bootstrap associated
  • nic-row -- same as above
  • vm-snapshot -- imports columnClassfrom external file
  • vm-nics -- imports columnClass from external file
  • vm-snapshot-row -- column class is a prop

@glekner
Copy link
Contributor

glekner commented Jun 17, 2021

/approve

@nemesis09
Copy link
Contributor

verified locally
works as expected
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 18, 2021
rohitkrai03
rohitkrai03 approved these changes Jun 21, 2021
View reviewed changes
Copy link
Contributor

@rohitkrai03 rohitkrai03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 21, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinandan13jan, afreen23, glekner, nemesis09, rohitkrai03

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 21, 2021
@andrewballantyne
Copy link
Contributor

Looks like internal errors with google apis... I'm not going to retest right now because I think it's best to let the bot do it (hopefully it's wiser to the success rate of external apis and their stability)

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@jerolimov
Copy link
Member

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

9 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 6722fa6 into openshift:master Jun 23, 2021
@spadgett spadgett added this to the v4.9 milestone Jul 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rohitkrai03 rohitkrai03 rohitkrai03 approved these changes

@afreen23 afreen23 afreen23 approved these changes

@honza honza Awaiting requested review from honza

Assignees

@nemesis09 nemesis09

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/ceph Related to ceph-storage-plugin component/kubevirt Related to kubevirt-plugin component/metal3 Related to metal3-plugin component/network-attachment-definition Related to network-attachment-definition lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
v4.9
Development

Successfully merging this pull request may close these issues.

None yet
10 participants
@abhinandan13jan @andrewballantyne @glekner @nemesis09 @openshift-bot @jerolimov @rohitkrai03 @afreen23 @spadgett @openshift-merge-robot