[release-4.7] Bug 1967106: can't open terminal for pods that have more than one co… #9117
Conversation
…an one container running
This fix uses a valid range for the refresh function of xterm, starting with row 0 and ending at rows-1.
Invalid start and end parameters were being passed to the refresh function of xterm during the switching of container terminals. This caused an exception when attempting to switch container terminals.
Per the xterm code:
/**
* Tells the renderer to refresh terminal content between two rows
* (inclusive) at the next opportunity.
* @param start The row to start from (between 0 and this.rows - 1).
* @param end The row to end at (between start and this.rows - 1).
*/
|
@openshift-cherrypick-robot: Bugzilla bug 1956920 has been cloned as Bugzilla bug 1967106. Retitling PR to link against new bug. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
changed the title
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: openshift-cherrypick-robot, spadgett The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
@openshift-cherrypick-robot: An error was encountered querying GitHub for users with public email (yapei@redhat.com) for bug 1967106 on the Bugzilla server at https://bugzilla.redhat.com. No known errors were detected, please see the full error message for details. Full error message.
non-200 OK status code: 403 Forbidden body: "{\n \"documentation_url\": \"https://docs.github.com/en/free-pro-team@latest/rest/overview/resources-in-the-rest-api#abuse-rate-limits\",\n \"message\": \"You have triggered an abuse detection mechanism. Please wait a few minutes before you try again.\"\n}\n"
Please contact an administrator to resolve this issue, then request a bug refresh with In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/bugzilla refresh |
openshift-ci
bot
added
bugzilla/severity-medium
|
@spadgett: This pull request references Bugzilla bug 1967106, which is valid. 6 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Tested against the pr, when switch from default terminal to the second terminal, the second container terminal could show up correctly, but when switch back to the first container terminal, the error shows up. This issue happens when my browser language is Chinese, but it's not always reproduced. |
ecordell
added
the
cherry-pick-approved
|
@openshift-cherrypick-robot: All pull requests linked via external trackers have merged: Bugzilla bug 1967106 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Hi, @yanpzhan. I believe that's unrelated to the PR... Do you mind opening a separate Bugzilla? |
This is an automated cherry-pick of #8853
/assign spadgett