Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.7] Bug 1969536: Omit bitbucket branch in URL if it contains slash #9180

Merged
merged 1 commit into from Jun 16, 2021
Merged

[release-4.7] Bug 1969536: Omit bitbucket branch in URL if it contains slash #9180

merged 1 commit into from Jun 16, 2021

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #9111

/assign rottencandy

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jun 8, 2021
Merged
4 tasks
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 8, 2021

@openshift-cherrypick-robot: Bugzilla bug 1969535 has been cloned as Bugzilla bug 1969536. Retitling PR to link against new bug.
/retitle [release-4.7] Bug 1969536: Omit bitbucket branch in URL if it contains slash

In response to this:

[release-4.7] Bug 1969535: Omit bitbucket branch in URL if it contains slash

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot changed the title [release-4.7] Bug 1969535: Omit bitbucket branch in URL if it contains slash [release-4.7] Bug 1969536: Omit bitbucket branch in URL if it contains slash Jun 8, 2021
@openshift-ci openshift-ci bot added the bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. label Jun 8, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 8, 2021

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1969536, which is invalid:

  • expected dependent Bugzilla bug 1969535 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is MODIFIED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

[release-4.7] Bug 1969536: Omit bitbucket branch in URL if it contains slash

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Jun 8, 2021
@openshift-ci openshift-ci bot added the component/topology Related to topology label Jun 8, 2021
@rottencandy
Copy link
Contributor

/cc @rohitkrai03

@openshift-ci openshift-ci bot requested a review from rohitkrai03 June 8, 2021 14:48
@rottencandy
Copy link
Contributor

/cherrypick release-4.6

@openshift-cherrypick-robot
Copy link
Author

@rottencandy: once the present PR merges, I will cherry-pick it on top of release-4.6 in a new PR and assign it to you.

In response to this:

/cherrypick release-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

andrewballantyne
andrewballantyne approved these changes Jun 9, 2021
View reviewed changes
Copy link
Contributor

@andrewballantyne andrewballantyne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 9, 2021
@andrewballantyne
Copy link
Contributor

/bugzilla refresh

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 9, 2021

@andrewballantyne: This pull request references Bugzilla bug 1969536, which is invalid:

  • expected dependent Bugzilla bug 1969535 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@rottencandy
Copy link
Contributor

/bugzilla refresh

@openshift-ci openshift-ci bot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jun 9, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 9, 2021

@rottencandy: This pull request references Bugzilla bug 1969536, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.z) matches configured target release for branch (4.7.z)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1969535 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
  • dependent Bugzilla bug 1969535 targets the "4.8.0" release, which is one of the valid target releases: 4.8.0
  • bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (gamore@redhat.com), skipping review request.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Jun 9, 2021
rohitkrai03
rohitkrai03 approved these changes Jun 9, 2021
View reviewed changes
Copy link
Contributor

@rohitkrai03 rohitkrai03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 9, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andrewballantyne, openshift-cherrypick-robot, rohitkrai03

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@rottencandy
Copy link
Contributor

/cherrypick release-4.6

@openshift-cherrypick-robot
Copy link
Author

@rottencandy: once the present PR merges, I will cherry-pick it on top of release-4.6 in a new PR and assign it to you.

In response to this:

/cherrypick release-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mfojtik mfojtik added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jun 16, 2021
@mfojtik
Copy link
Member

mfojtik commented Jun 16, 2021

[patch-manager] 🚀 Approved for z-stream by score: 0.20

approved

@openshift-merge-robot openshift-merge-robot merged commit 4ef7c88 into openshift:release-4.7 Jun 16, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 16, 2021

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged:

Bugzilla bug 1969536 has been moved to the MODIFIED state.

In response to this:

[release-4.7] Bug 1969536: Omit bitbucket branch in URL if it contains slash

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jun 16, 2021
Merged
@openshift-cherrypick-robot
Copy link
Author

@rottencandy: new pull request created: #9271

In response to this:

/cherrypick release-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett spadgett added this to the v4.7.z milestone Aug 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rohitkrai03 rohitkrai03 rohitkrai03 approved these changes

@andrewballantyne andrewballantyne andrewballantyne approved these changes

@divyanshiGupta divyanshiGupta Awaiting requested review from divyanshiGupta

@vikram-raj vikram-raj Awaiting requested review from vikram-raj

Assignees

@rohitkrai03 rohitkrai03

@andrewballantyne andrewballantyne

@rottencandy rottencandy

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. component/topology Related to topology lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
v4.7.z
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@openshift-cherrypick-robot @rottencandy @andrewballantyne @openshift-bot @mfojtik @rohitkrai03 @spadgett @openshift-merge-robot