Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1967275: Prevent awkward wrap of icons with getting started links and buttons #9184

Merged

Conversation

sg00dwin
Copy link
Member

@sg00dwin sg00dwin commented Jun 8, 2021

Fixes bug https://bugzilla.redhat.com/show_bug.cgi?id=1967275

Note: I had to switch the icons to display as appended Pseudo-class :after elements in order to keep them from wrapping within their parent elements that are displayed as flex containers.

Screen Shot 2021-06-08 at 2 53 48 PM

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 8, 2021

@sg00dwin: An error was encountered querying GitHub for users with public email (yapei@redhat.com) for bug 1967275 on the Bugzilla server at https://bugzilla.redhat.com. No known errors were detected, please see the full error message for details.

Full error message. Post "http://ghproxy/graphql": dial tcp 172.30.229.2:80: i/o timeout

Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.

In response to this:

Bug 1967275: Prevent awkward wrap of icons with getting started links and buttons

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sg00dwin
Copy link
Member Author

sg00dwin commented Jun 8, 2021

/bugzilla refresh

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 8, 2021

@sg00dwin: An error was encountered querying GitHub for users with public email (yapei@redhat.com) for bug 1967275 on the Bugzilla server at https://bugzilla.redhat.com. No known errors were detected, please see the full error message for details.

Full error message. Post "http://ghproxy/graphql": dial tcp 172.30.229.2:80: i/o timeout

Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 8, 2021
@openshift-ci openshift-ci bot requested review from rhamilto and zherman0 June 8, 2021 20:57
@openshift-ci openshift-ci bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality component/shared Related to console-shared labels Jun 8, 2021
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jun 8, 2021
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 9, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 9, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sg00dwin, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@sg00dwin
Copy link
Member Author

sg00dwin commented Jun 9, 2021

/retest

@spadgett
Copy link
Member

spadgett commented Jun 9, 2021

/refresh

@openshift-merge-robot openshift-merge-robot merged commit 7a5e04f into openshift:master Jun 9, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 9, 2021

@sg00dwin: All pull requests linked via external trackers have merged:

Bugzilla bug 1967275 has been moved to the MODIFIED state.

In response to this:

Bug 1967275: Prevent awkward wrap of icons with getting started links and buttons

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sg00dwin sg00dwin deleted the append-icon-bug1967275 branch June 10, 2021 13:57
@spadgett spadgett added this to the v4.8 milestone Jun 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality component/shared Related to console-shared lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants