Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add kubevirt pvc upload test #9186

Merged
merged 1 commit into from Jun 22, 2021
Merged

add kubevirt pvc upload test #9186

merged 1 commit into from Jun 22, 2021

Conversation

gouyang
Copy link
Contributor

@gouyang gouyang commented Jun 9, 2021 •
edited

convert protractor test cdi-upload.scenario.ts to cypress test.

@openshift-ci openshift-ci bot added the component/kubevirt Related to kubevirt-plugin label Jun 9, 2021
@gouyang
Copy link
Contributor Author

gouyang commented Jun 9, 2021 •
edited

/hold until #8997 merged

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 9, 2021
@openshift-ci openshift-ci bot added the kind/cypress Related to Cypress e2e integration testing label Jun 9, 2021
@gouyang gouyang force-pushed the pvc_upload branch 4 times, most recently from 8be3606 to f111a4f Compare June 11, 2021 11:34
@gouyang
Copy link
Contributor Author

gouyang commented Jun 12, 2021

/retest

1 similar comment
@gouyang
Copy link
Contributor Author

gouyang commented Jun 12, 2021

/retest

@gouyang
Copy link
Contributor Author

gouyang commented Jun 15, 2021

@yaacov @pcbailey PTAL.

pcbailey
pcbailey reviewed Jun 15, 2021
View reviewed changes
frontend/packages/kubevirt-plugin/integration-tests-cypress/tests/pvc-upload/pvc-upload.ts Outdated Show resolved Hide resolved
frontend/packages/kubevirt-plugin/integration-tests-cypress/tests/pvc-upload/pvc-upload.ts Outdated
namespace: vmData.namespace,
},
});
cy.exec('rm -fr /tmp/cirror*');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should that be '/tmp/cirros*'?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use a regex here because it has cirros.{iso, img, gz, xz, txt}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sorry. I should have been clearer in my question. There's a typo. It currently says 'cirroR*' instead of 'cirroS*'.

frontend/packages/kubevirt-plugin/integration-tests-cypress/tests/pvc-upload/pvc-upload.ts Outdated Show resolved Hide resolved
frontend/packages/kubevirt-plugin/integration-tests-cypress/tests/pvc-upload/pvc-upload.ts Outdated Show resolved Hide resolved
frontend/packages/kubevirt-plugin/integration-tests-cypress/tests/pvc-upload/pvc-upload.ts Outdated Show resolved Hide resolved
frontend/packages/kubevirt-plugin/integration-tests-cypress/view/vm.ts Outdated Show resolved Hide resolved
@yaacov
Copy link
Member

yaacov commented Jun 16, 2021

/hold cancel
#8997 is merged

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 16, 2021
@gouyang gouyang force-pushed the pvc_upload branch 2 times, most recently from d2c7562 to 708c673 Compare June 16, 2021 12:04
@gouyang
Copy link
Contributor Author

gouyang commented Jun 16, 2021

/retest

@gouyang
Copy link
Contributor Author

gouyang commented Jun 17, 2021

/retest

@gouyang
Copy link
Contributor Author

gouyang commented Jun 17, 2021

@pcbailey Could you review again?

pcbailey
pcbailey reviewed Jun 22, 2021
View reviewed changes
frontend/packages/kubevirt-plugin/integration-tests-cypress/tests/pvc-upload/pvc-upload.ts Outdated
});

describe('test PVC upload via CLI', () => {
it('ID(CNV-5044) Verify boot source is available for template after upload via cli', () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick: You missed one CLI at the end of the title

frontend/packages/kubevirt-plugin/integration-tests-cypress/tests/pvc-upload/pvc-upload.ts Outdated
virtualization.templates.testSource(TEMPLATE_NAME, 'Unknown');
});

it('ID(CNV-5597) Verify create VM from the template which source is uploaded via CLI', () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick: which -> whose

@pcbailey
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 22, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 22, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gouyang, pcbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 22, 2021
@yaacov
Copy link
Member

yaacov commented Jun 22, 2021

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit a132d29 into openshift:master Jun 22, 2021
@spadgett spadgett added this to the v4.9 milestone Jul 14, 2021
@gouyang gouyang deleted the pvc_upload branch August 23, 2021 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pcbailey pcbailey pcbailey left review comments

@glekner glekner Awaiting requested review from glekner

@vojtechszocs vojtechszocs Awaiting requested review from vojtechszocs

Assignees

@pcbailey pcbailey

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/kubevirt Related to kubevirt-plugin kind/cypress Related to Cypress e2e integration testing lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
v4.9
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@gouyang @yaacov @pcbailey @openshift-bot @spadgett @openshift-merge-robot