Capitalize help text for when expressions in the task sidebar

[debsmita1]

Fixes:
https://issues.redhat.com/browse/ODC-5943

Screenshot:

[debsmita1]

/cc @bgliwa01
/assign @andrewballantyne

[andrewballantyne]

This covers the situation... I want to now go on an easter egg hunt to see if anything else is missing. So Brigid doesn't need to log another issue in a few days 😄

[bgliwa01]

Help text looks good! The dropdown for operator should be "Select operator" in order to comply with sentence case

[andrewballantyne]

For posterity, I've inquired with @bgliwa01 about the two different wordings we have for using $(...

Ah, interesting, we have two wordings
Use this format when referencing variables in this form: <code>$(</code> (params)
vs
Use this format while referencing the variables in this form: <code>$(</code> (when)

[andrewballantyne]

@debsmita1 Would you mind updating some of the error text to have proper sentence case; missing period in messages found in frontend/packages/pipelines-plugin/src/components/pipelines/pipeline-builder/validation-utils.ts:

• Resource type has changed, reselect
• Workspace name has changed, reselect
• TaskSpec or TaskRef must be provided
• Must define at least one Task

Last two may not appear today, but it's best to just align it.

[bgliwa01]

For posterity, I've inquired with @bgliwa01 about the two different wordings we have for using $(...

Ah, interesting, we have two wordings
Use this format when referencing variables in this form: <code>$(</code> (params)
vs
Use this format while referencing the variables in this form: <code>$(</code> (when)

After talking to content, it should be "Use this format when you reference variables in this form: $("

[debsmita1]

@andrewballantyne Should I change Must define at least one Task to Must define at least one task ? or should I simply add period to this ?

[andrewballantyne]

@andrewballantyne Should I change Must define at least one Task to Must define at least one task ? or should I simply add period to this ?

Oooh, yeah task please. Task is not the resource, it's a concept in the Pipeline. Good catch.

[debsmita1]

@andrewballantyne Should I change Must define at least one Task to Must define at least one task ? or should I simply add period to this ?

Oooh, yeah task please. Task is not the resource, it's a concept in the Pipeline. Good catch.

Aslo ,

and

to Remove task and Select task respectively ?

[andrewballantyne]

@andrewballantyne Should I change Must define at least one Task to Must define at least one task ? or should I simply add period to this ?

Oooh, yeah task please. Task is not the resource, it's a concept in the Pipeline. Good catch.

Aslo ,

and

to Remove task and Select task respectively ?

Ah yeah, same reason. I read that and went "yeah, no that's correct" but in reality it is not. Also please change the modal.

[debsmita1]

/kind bug

[andrewballantyne]

Secret is a k8s resource. Capital is correct I believe.

cc @bgliwa01

[jerolimov]

Just fyi:

But I also know that Secret is here "exact a Secret resource" and the values in the dropdown are talking about the concept "secret" ... Anyway a little bit confusing.

[andrewballantyne]

A fair point 🤷

[bgliwa01]

When secret is referred to as a resource it should be capital

[debsmita1]

Done

[andrewballantyne]

There are some test failures too, that vet text you modified.

[debsmita1]

There are some test failures too, that vet text you modified.

Fixed the failing tests

[bgliwa01]

lgtm

[jerolimov]

/lgtm

[andrewballantyne]

/hold

@debsmita1 can we address the Secret issue I mentioned above before merge to avoid another bug to address it.

[debsmita1]

/hold

@debsmita1 can we address the Secret issue I mentioned above before merge to avoid another bug to address it.

Done

[andrewballantyne]

/lgtm
/unhold

Thanks @debsmita1 !

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andrewballantyne, bgliwa01, debsmita1, jerolimov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• frontend/packages/pipelines-plugin/OWNERS [andrewballantyne,jerolimov]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment