Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-4.8] Bug 1971911: Do not render samples column and helm link when add page customization disabled them #9240

Conversation

openshift-cherrypick-robot

This is an automated cherry-pick of #9228

/assign jerolimov

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 14, 2021

@openshift-cherrypick-robot: Bugzilla bug 1971499 has been cloned as Bugzilla bug 1971911. Retitling PR to link against new bug.
/retitle [release-4.8] Bug 1971911: Do not render samples column and helm link when add page customization disabled them

In response to this:

[release-4.8] Bug 1971499: Do not render samples column and helm link when add page customization disabled them

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot changed the title [release-4.8] Bug 1971499: Do not render samples column and helm link when add page customization disabled them [release-4.8] Bug 1971911: Do not render samples column and helm link when add page customization disabled them Jun 14, 2021
@openshift-ci openshift-ci bot added component/dev-console Related to dev-console component/shared Related to console-shared bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. labels Jun 14, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 14, 2021

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1971911, which is invalid:

  • expected dependent Bugzilla bug 1971499 to be in one of the following states: MODIFIED, VERIFIED, but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

[release-4.8] Bug 1971911: Do not render samples column and helm link when add page customization disabled them

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Jun 14, 2021
@jerolimov
Copy link
Member

/retest

@jcaianirh jcaianirh removed their request for review June 15, 2021 18:10
@jerolimov
Copy link
Member

/retest
/cc @nemesis09

@openshift-ci openshift-ci bot requested a review from nemesis09 June 15, 2021 18:20
@jerolimov
Copy link
Member

/retest
/assign @invincibleJai
/bugzilla refresh

@openshift-ci openshift-ci bot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jun 22, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 22, 2021

@jerolimov: This pull request references Bugzilla bug 1971911, which is valid.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.8.0) matches configured target release for branch (4.8.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1971499 is in the state VERIFIED, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Bugzilla bug 1971499 targets the "4.9.0" release, which is one of the valid target releases: 4.9.0
  • bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (gamore@redhat.com), skipping review request.

In response to this:

/retest
/assign @invincibleJai
/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Jun 22, 2021
@jerolimov
Copy link
Member

/retest

@jerolimov
Copy link
Member

/approve

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 28, 2021
@nemesis09
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 28, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 28, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jerolimov, nemesis09, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sdodson
Copy link
Member

sdodson commented Jul 22, 2021

Re-validating bugzilla status after prow config updates.
/bugzilla refresh

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 22, 2021

@sdodson: This pull request references Bugzilla bug 1971911, which is valid.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.8.z) matches configured target release for branch (4.8.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1971499 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
  • dependent Bugzilla bug 1971499 targets the "4.9.0" release, which is one of the valid target releases: 4.9.0
  • bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (gamore@redhat.com), skipping review request.

In response to this:

Re-validating bugzilla status after prow config updates.
/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ecordell
Copy link
Contributor

ecordell commented Aug 4, 2021

[patch-manager] ⌛ This pull request was not picked by the patch manager for the current z-stream window and have to wait for the next window.

skipped

  • Score: 0.20
  • Reason: missed cutoff today, may make it tomorrow

NOTE: This message was automatically generated, if you have questions please ask on #forum-release

1 similar comment
@ecordell
Copy link
Contributor

ecordell commented Aug 5, 2021

[patch-manager] ⌛ This pull request was not picked by the patch manager for the current z-stream window and have to wait for the next window.

skipped

  • Score: 0.20
  • Reason: missed cutoff today, may make it tomorrow

NOTE: This message was automatically generated, if you have questions please ask on #forum-release

@ecordell
Copy link
Contributor

ecordell commented Aug 5, 2021

[patch-manager] ⌛ This pull request was not picked by the patch manager for the current z-stream window and have to wait for the next window.

skipped

  • Score: 0.20
  • Reason: missed cutoff for today, may make tomorrow

NOTE: This message was automatically generated, if you have questions please ask on #forum-release

@ecordell
Copy link
Contributor

ecordell commented Aug 6, 2021

[patch-manager] ⌛ This pull request was not picked by the patch manager for the current z-stream window and have to wait for the next window.

skipped

  • Score: 0.20
  • Reason: skipping for now, may still be tagged today

NOTE: This message was automatically generated, if you have questions please ask on #forum-release

@ecordell ecordell added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Aug 6, 2021
@ecordell
Copy link
Contributor

ecordell commented Aug 6, 2021

[patch-manager] 🚀 Approved for z-stream by score: 0.20

picked

@jerolimov
Copy link
Member

/test e2e-gcp-console

@openshift-ci openshift-ci bot merged commit 3c9fb22 into openshift:release-4.8 Aug 7, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 7, 2021

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged:

Bugzilla bug 1971911 has been moved to the MODIFIED state.

In response to this:

[release-4.8] Bug 1971911: Do not render samples column and helm link when add page customization disabled them

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett spadgett added this to the v4.8.z milestone Aug 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. component/dev-console Related to dev-console component/shared Related to console-shared lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants