Add enhancements to GitOpsDetailsPage

[reginapizza]

This is our WIP PR for GitOps work to be done in 4.9, outlined in ODC-5841.
At the moment, only Details Page (overview) is included, Deployment History page will be contributed by @keithchong. These changes are purely UI; backend changes still need to go in and dummy data needs to be replaced.

Just creating this early for more visibility and earlier code reviews where/when possible. (Will include more screenshots later on)

@andrewballantyne @bgliwa01 @serenamarie125

[andrewballantyne]

Need to do a rebase @reginapizza

[andrewballantyne]

Some initial feedback @reginapizza -- Please let me know if you have any questions or concerns about what I mentioned here.

[andrewballantyne]

Looks WIP-esk... but don't forget to put React keys.

[reginapizza]

this is the area that Keith will be contributing. Likely most of this will be overwritten.

[andrewballantyne]

Is this something that was intended to be removed?

[keithchong]

@reginapizza , I created a commit in your repo reginapizza@0c3dac2
that should give you a head start on showing 'live' data. I made changes for the 'Resources' section of the card, which shows the deployments, services, and secrets. Note that this is still based on your old branch that needed to be rebased. However, it shouldn't be too difficult to merge the changes to your updated branch (only 7 file changes).

Here is a screen shot. The counts are showing, and the number of non-healthy resources do appear.

If the frontend is talking to an 'older' backend, the resource count will not be '0' but rather, 'N/A', like so.
@serenamarie125 , @wtam2018 , do you prefer it to be displayed some other way?

[keithchong]

Hi @reginapizza , was the design changed such that the cards are shown only in one column? Could you confirm that you are seeing this too?

[reginapizza]

@keithchong when I looked at the cluster you sent yesterday they were being displayed side by side... the design hasn't changed though

[andrewballantyne]

As discussed in our chat, feel free to take some of these refactor notes as suggestions for post 4.9. There isn't too much to worry about here from a bug perspective. Perhaps the lack of error handling can bite you if things go off the rails.

[andrewballantyne]

Is it possible to have envs that are null or undefined? Because you do a env && at the start of the map which adds an indent. I would think if you could have bad envs you should filter them out first before mapping to improve readability and save an indent (this component has a lot of indentation).

[andrewballantyne]

Dropping WIP
/retitle Add enhancements to GitOpsDetailsPage

Updating state based on what I've done
/kind feature
/label qe-approved

Apply labels from Epic
/label px-approved
/label docs-approved

Adding Keith as a reviewer for the lgtm:
/assign @keithchong

[andrewballantyne]

/approve

The bot is having some issues, but for the clear record, I approve of the state this PR is in. The changes unhandled will be taken up by the GitOps team post 4.9 and hopefully added to a dynamic plugin which will slot over the work done in 4.9. @reginapizza please don't forget to file a ticket in the GitOps Jira to keep track of these things, I do think they are important.

[keithchong]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andrewballantyne, keithchong, reginapizza

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• frontend/packages/gitops-plugin/OWNERS [andrewballantyne]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment