Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix monitoring error box alignment #9245

Merged
merged 1 commit into from Jun 15, 2021

Conversation

jerolimov
Copy link
Member

@jerolimov jerolimov commented Jun 15, 2021

Fixes:
https://issues.redhat.com/browse/ODC-5997

Analysis / Root cause:
Error message is aligned with a flex layout to the center.

Solution Description:
Stretch the content of the flex layout.

I tested also the admin monitoring area but didn't find any difference.

Screen shots / Gifs for design review:
Before (in case of an error, for example with a local CRC):
monitoring-error-before

With this PR and an error (local CRC):
with-pr-without-monitoring

With this PR and installed monitoring (shared cluster):
with-pr-with-monitoring

Unit test coverage report:
Unchanged. CSS only change.

Test setup:

  • To get the error use a CRC
  • Alternative: switch to monitoring tab (to load the JS), switch back, disconnect from internet or stop a local bridge, and switch back to the monitoring tab

Browser conformance:

  • Chrome
  • Firefox
  • Safari
  • Edge

@openshift-ci openshift-ci bot requested review from kyoto and spadgett June 15, 2021 07:23
@openshift-ci openshift-ci bot added component/core Related to console core functionality component/monitoring Related to monitoring approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 15, 2021
@jerolimov
Copy link
Member Author

/cc @vikram-raj

@openshift-ci openshift-ci bot requested a review from vikram-raj June 15, 2021 07:31
@jerolimov
Copy link
Member Author

/kind bug

@openshift-ci openshift-ci bot added the kind/bug Categorizes issue or PR as related to a bug. label Jun 15, 2021
Copy link
Member

@vikram-raj vikram-raj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

verified the changes and its looks good to me.

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 15, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jerolimov, vikram-raj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 15, 2021
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 72fbfc8 into openshift:master Jun 15, 2021
@spadgett spadgett added this to the v4.9 milestone Jul 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality component/monitoring Related to monitoring kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants