CONSOLE-2810: Update react-jsonschema-form package #9261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
do-not-merge/work-in-progress
openshift-ci
bot
added
component/helm
frontend/packages/console-shared/src/components/dynamic-form/fields.tsx
Outdated
Show resolved
Hide resolved
TheRealJon
reviewed
Jun 15, 2021
frontend/packages/console-shared/src/components/dynamic-form/fields.tsx
Outdated
Show resolved
Hide resolved
cyril-ui-developer
force-pushed
the
update-react-jsonschema-form-package
branch
from
5bae53f
to
8b34a85
Compare
cyril-ui-developer
changed the title
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
cyril-ui-developer
force-pushed
the
update-react-jsonschema-form-package
branch
from
8b34a85
to
d53c410
Compare
|
@TheRealJon Updated! Thanks. |
TheRealJon
reviewed
Jun 30, 2021
frontend/packages/console-shared/src/components/dynamic-form/fields.tsx
Outdated
Show resolved
Hide resolved
cyril-ui-developer
force-pushed
the
update-react-jsonschema-form-package
branch
2 times, most recently
from
2ebdee1
to
e9e2134
Compare
openshift-ci
bot
added
the
needs-rebase
cyril-ui-developer
force-pushed
the
update-react-jsonschema-form-package
branch
from
e9e2134
to
aab7af0
Compare
openshift-ci
bot
removed
the
needs-rebase
|
/retest |
|
/label px-approved |
openshift-ci
bot
added
the
px-approved
|
build a local console with |
openshift-ci
bot
added
the
qe-approved
|
No user-visible changes. Adding the docs-approved label. /label docs-approved |
openshift-ci
bot
added
do-not-merge/hold
|
/hold cancel |
openshift-ci
bot
added
needs-rebase
cyril-ui-developer
force-pushed
the
update-react-jsonschema-form-package
branch
from
aab7af0
to
5c5f0f9
Compare
openshift-ci
bot
removed
lgtm
|
@spadgett I rebased, so it needs lgtm label again. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cyril-ui-developer, spadgett, TheRealJon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/assign @TheRealJon
cc: @rhamilto
The warning error -
Warning: validateDOMNesting(...): <form> cannot appear as a descendant of <form>.that I mentioned in scrum today is gone after I changed theimportstatement ofSchemaFieldandSchemaFieldPropsfrom'react-jsonschema-form/lib/components/fields/SchemaField'to'@rjsf/core/dist/cjs/components/fields/SchemaField';