Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Monitoring: Remove Prometheus UI link and SERVER_FLAGS.*PublicURL entries #9283

Merged
merged 2 commits into from Jun 24, 2021
Merged

Monitoring: Remove Prometheus UI link and SERVER_FLAGS.*PublicURL entries #9283

merged 2 commits into from Jun 24, 2021

Conversation

kyoto
Copy link
Member

@kyoto kyoto commented Jun 17, 2021 •
edited

Backend changes for removing the SERVER_FLAGS.*PublicURL entries are covered by #9276

@openshift-ci openshift-ci bot added component/core Related to console core functionality component/monitoring Related to monitoring approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated labels Jun 17, 2021
spadgett
spadgett approved these changes Jun 24, 2021
View reviewed changes
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 24, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 24, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kyoto, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@spadgett
Copy link
Member

We should look at removing these from the console operator as well since they're no longer used. Then we can remove the command line flags from the backend.

cc @jhadvig

@openshift-merge-robot openshift-merge-robot merged commit 2ba9eb4 into openshift:master Jun 24, 2021
@kyoto kyoto deleted the monitoring-remove-prometheus-ui-link branch June 24, 2021 23:37
@kyoto kyoto mentioned this pull request Jun 28, 2021
Closed
@spadgett spadgett added this to the v4.9 milestone Jul 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spadgett spadgett spadgett approved these changes

@jeff-phillips-18 jeff-phillips-18 Awaiting requested review from jeff-phillips-18

@TheRealJon TheRealJon Awaiting requested review from TheRealJon

Assignees

@spadgett spadgett

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality component/monitoring Related to monitoring kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
v4.9
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kyoto @spadgett @openshift-merge-robot