Fix that try sample and show adv option buttons could be clicked without Git URL in different import flows #9290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
component/dev-console
jerolimov
changed the title
|
/kind bug |
debsmita1
suggested changes
Jun 18, 2021
frontend/packages/dev-console/src/components/import/git/GitSection.tsx
Outdated
Show resolved
Hide resolved
frontend/packages/dev-console/src/components/import/git/GitSection.tsx
Outdated
Show resolved
Hide resolved
jerolimov
force-pushed
the
odc-5955-helptext
branch
from
2ba2b87
to
17a378c
Compare
It is approved by @beaumorley and @parvathyvr in this slack thread, but maybe one of you both could add a comment to this PR as well. Thanks :) |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: debsmita1, jerolimov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest Please review the full test history for this PR and help us cut down flakes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes:
https://issues.redhat.com/browse/ODC-5955
https://issues.redhat.com/browse/ODC-6016
Analysis / Root cause:
With 4.8 we automatically focus the Git URL (the first input field) when the user imports from Git, Dockerfile or Devfile.
When the user clicks then on "Try sample" or "Show advanced Git options" the url field losts his focus. The
onBlurmethod then marks the input field astouched(in formik) and show an error if the url field is empty.This "Required!" error was shown faster then the mentioned buttons handles their event. And because the "Required!" was added as a new label below the input field all buttons and input fields jumps a little but down and the user click on these buttons is ignored.
A second click works fine. Also if the user first lost the focus of the input field, and then select it again.
Solution Description:
Add a help text to the "Git Repo URL" field. This help text was replaced with the error message when the form field is empty (or invalid).
Also fixed a small flicking because
git.isUrlValidatingwas set to false before the validation status was set.The help text for the different cases are:
Solution was discussed with UX in slack #tmp-odc-add
Screen shots / Gifs for design review:
Before:
After:
Unit test coverage report:
Just added a new help text. Unit tests are not changed.
Test setup:
Browser conformance: