Migrate Helm actions on topology to use the new extensions #9313

debsmita1 · 2021-06-22T13:49:35Z

JIRA ticket:
https://issues.redhat.com/browse/ODC-5693

Solution description:

Updated the topology context menu actions for helm release to use the new extension

GIF/Screenshot:

debsmita1 · 2021-06-22T13:50:00Z

/assign @rohitkrai03

rohitkrai03

/hold

@debsmita1 This PR seems to be just using ActionLoader to get extension based action but still using the old KebabMenu components. The goal of the story was to use new KebabMenu components potentially after https://issues.redhat.com/browse/ODC-5749 which would lead to some more refactoring in how topology uses actions.

rohitkrai03 · 2021-06-22T15:03:36Z

frontend/packages/helm-plugin/src/topology/TopologyHelmReleasePanel.tsx

-          )}
+          <div className="co-actions">
+            <ActionsLoader contextId="helm-actions" scope={actionsScope}>
+              {(actions, loaded) => loaded && <ActionsMenu actions={actions} />}


Does this actually work? Type of the actions coming from extensions is a bit different than that of old actions. Seems like this would break somewhere.

debsmita1 · 2021-07-06T14:11:34Z

frontend/packages/console-shared/src/components/actions/menu/ActionMenuContent.tsx

-                  onClick={onClick}
-                  autoFocus={focusItem ? option === focusItem : undefined}
-                />
+                <div className="pf-c-dropdown__menu-item">


Added this so that the menu items in the context menu are rendered with proper spacing and are focused when the cursor hovers on them

This might add some unnecessary styles to normal menu items.

debsmita1 · 2021-07-07T07:20:27Z

Fixing the alignment of the Sub Menu and grouped menu items in the Context Menu

rohitkrai03 · 2021-07-07T09:34:36Z

@debsmita1 #9306 just merged. So you can remove the duplicate changes from this PR now.

rohitkrai03 · 2021-07-07T12:12:58Z

frontend/packages/console-shared/src/components/actions/menu/ActionMenuContent.tsx

-                  onClick={onClick}
-                  autoFocus={focusItem ? option === focusItem : undefined}
-                />
+                <div className="pf-c-dropdown__menu-item">


This might add some unnecessary styles to normal menu items.

rohitkrai03 · 2021-07-07T12:14:09Z

frontend/packages/topology/src/actions/contextMenuActions.tsx

+export const contextMenuActions = (element: Node): React.ReactElement[] => {
+  return [
+    <ActionsLoader contextId="topology-actions" scope={element}>
+      {(loader) => loader.loaded && <ActionMenuContent options={loader.options} />}


Not sending an onClick handler keeps the context menu open even after the callback has been called.

Changed the implementation here. PTAL

debsmita1 · 2021-07-07T20:15:41Z

Fixing the alignment of the Sub Menu and grouped menu items in the Context Menu

Created util createContextMenuItems which returns the context menu items in a way similar to the menu rendering logic in ActionMenuContent

debsmita1 · 2021-07-07T20:17:17Z

/cc @christianvogt
/cc @sahil143

debsmita1 · 2021-07-07T20:17:42Z

/hold cancel

sahil143 · 2021-07-08T07:32:12Z

frontend/packages/console-dynamic-plugin-sdk/src/extensions/actions.ts

  label: string;
+  /**  To send translation key for label */
+  labelKey?: string;


I don't think we need this prop. Since all new extensions are hook based, strings will be translated in the hook itself

christianvogt · 2021-07-08T15:28:56Z

frontend/packages/topology/src/actions/contextMenuActions.tsx

+export const contextMenuActions = (element: Node): React.ReactElement[] => {
+  return [
+    <ActionsLoader
+      key={`topology-actions-${element.getType()}`}


key here can be a constant because there's no conflicts
topology is sufficient

christianvogt · 2021-07-08T15:35:21Z

frontend/packages/topology/src/actions/contextMenuActions.tsx

+  return [
+    <ActionsLoader
+      key={`topology-actions-${element.getType()}`}
+      contextId="topology-actions"


We also need resource contextId for this util to be reused for other nodes.

@rohitkrai03 we need a way to avoid doing it this way and have a single loader

Yeah, I am working on adding support for resource actions in action loader. So we can provide the resource model along with contextId to the action loader and get back all the actions for a specific resource as well as a context.

do we put this PR on hold till then ?

I think we can get this merged now. The follow up story that I am working on will take care of resource actions.

rohitkrai03

/lgtm
/approve

openshift-ci · 2021-07-09T16:59:28Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: debsmita1, rohitkrai03

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~frontend/packages/helm-plugin/OWNERS~~ [rohitkrai03]
~~frontend/packages/topology/OWNERS~~ [rohitkrai03]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci bot requested review from abhinandan13jan and karthikjeeyar June 22, 2021 13:49

openshift-ci bot added component/core Related to console core functionality component/helm Related to helm-plugin component/topology Related to topology labels Jun 22, 2021

openshift-ci bot assigned rohitkrai03 Jun 22, 2021

rohitkrai03 reviewed Jun 22, 2021

View reviewed changes

openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 22, 2021

rohitkrai03 suggested changes Jun 22, 2021

View reviewed changes

debsmita1 changed the title ~~Migrate Helm actions on topology to use the new extensions~~ [WIP] Migrate Helm actions on topology to use the new extensions Jun 23, 2021

openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 23, 2021

debsmita1 force-pushed the helm-actions branch from 3ea481d to 3516f7c Compare July 6, 2021 13:00

openshift-ci bot added the component/shared Related to console-shared label Jul 6, 2021

debsmita1 force-pushed the helm-actions branch from 3516f7c to 9be3c9f Compare July 6, 2021 13:02

debsmita1 changed the title ~~[WIP] Migrate Helm actions on topology to use the new extensions~~ Migrate Helm actions on topology to use the new extensions Jul 6, 2021

openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 6, 2021

debsmita1 requested a review from rohitkrai03 July 6, 2021 13:10

debsmita1 commented Jul 6, 2021

View reviewed changes

rohitkrai03 suggested changes Jul 7, 2021

View reviewed changes

debsmita1 force-pushed the helm-actions branch from 9be3c9f to c400e36 Compare July 7, 2021 20:03

openshift-ci bot added the component/sdk Related to console-plugin-sdk label Jul 7, 2021

debsmita1 force-pushed the helm-actions branch from c400e36 to 914c18c Compare July 7, 2021 20:05

debsmita1 requested a review from rohitkrai03 July 7, 2021 20:16

openshift-ci bot requested review from christianvogt and sahil143 July 7, 2021 20:17

openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 7, 2021

sahil143 suggested changes Jul 8, 2021

View reviewed changes

debsmita1 force-pushed the helm-actions branch from 914c18c to 561334e Compare July 8, 2021 07:58

debsmita1 requested a review from sahil143 July 8, 2021 07:59

christianvogt reviewed Jul 8, 2021

View reviewed changes

Migrate Helm actions on topology to use the new extensions

cd76a8c

debsmita1 force-pushed the helm-actions branch from 561334e to cd76a8c Compare July 8, 2021 19:11

rohitkrai03 approved these changes Jul 9, 2021

View reviewed changes

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 9, 2021

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 9, 2021

openshift-merge-robot merged commit c224f28 into openshift:master Jul 9, 2021

spadgett added this to the v4.9 milestone Jul 14, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Migrate Helm actions on topology to use the new extensions #9313

Migrate Helm actions on topology to use the new extensions #9313

debsmita1 commented Jun 22, 2021 •

edited

debsmita1 commented Jun 22, 2021

rohitkrai03 left a comment

rohitkrai03 Jun 22, 2021

debsmita1 Jul 6, 2021

rohitkrai03 Jul 7, 2021

debsmita1 commented Jul 7, 2021

rohitkrai03 commented Jul 7, 2021

rohitkrai03 Jul 7, 2021

rohitkrai03 Jul 7, 2021

debsmita1 Jul 7, 2021

debsmita1 commented Jul 7, 2021

debsmita1 commented Jul 7, 2021

debsmita1 commented Jul 7, 2021

sahil143 Jul 8, 2021

christianvogt Jul 8, 2021

christianvogt Jul 8, 2021

rohitkrai03 Jul 8, 2021

debsmita1 Jul 8, 2021

rohitkrai03 Jul 8, 2021

rohitkrai03 left a comment

openshift-ci bot commented Jul 9, 2021

Migrate Helm actions on topology to use the new extensions #9313

Migrate Helm actions on topology to use the new extensions #9313

Conversation

debsmita1 commented Jun 22, 2021 • edited

debsmita1 commented Jun 22, 2021

rohitkrai03 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

debsmita1 commented Jul 7, 2021

rohitkrai03 commented Jul 7, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

debsmita1 commented Jul 7, 2021

debsmita1 commented Jul 7, 2021

debsmita1 commented Jul 7, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rohitkrai03 left a comment

Choose a reason for hiding this comment

openshift-ci bot commented Jul 9, 2021

debsmita1 commented Jun 22, 2021 •

edited