Bug 1972011: Fix time range for drag & drop in devconsole monitoring

[vikram-raj]

Fixes:
https://issues.redhat.com/browse/OCPBUGSM-30920

Analysis / Root cause:
Dashboards display different time range when drag&drop on the first chart of the dashboard

Solution Description:
Dispatch the onZoom event so that it will reflect all the charts in the dashboard.

Screen shots / Gifs for design review:

[openshift-ci]

@vikram-raj: This pull request references Bugzilla bug 1972011, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.9.0) matches configured target release for branch (4.9.0)
• bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (gamore@redhat.com), skipping review request.

In response to this:

Bug 1972011: Fix time range for drag & drop in devconsole monitoring

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

@vikram-raj: This pull request references Bugzilla bug 1972011, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.9.0) matches configured target release for branch (4.9.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (gamore@redhat.com), skipping review request.

In response to this:

Bug 1972011: Fix time range for drag & drop in devconsole monitoring

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[vikram-raj]

/kind bug

[invincibleJai]

@vikram-raj do we need to preserve custom time range? i.e

• go to devconsole
• select valid project
• go to monitoring
• select time range with drag and deop
• go back to topology and move back to monitoring
• can see still time range is persisted.

I don't see harm but to be aware if this is expected as on the admin side we don't preserve

[kyoto]

Thanks @invincibleJai. I think it would be better if the change were not persisted.

Also, since this is using the same redux entries as the admin Console, this will cause the zoom settings to persist when switching from Dev to Admin Console.

It might be cleaner to use useReducer / useContext instead of Redux in this case (see https://reactjs.org/docs/hooks-faq.html#how-to-avoid-passing-callbacks-down). (Maybe the admin perspective should too.)

[andrewballantyne]

Thanks @invincibleJai. I think it would be better if the change were not persisted.

If this is the state we want to go with, then I've approved the current code.

Also, since this is using the same redux entries as the admin Console, this will cause the zoom settings to persist when switching from Dev to Admin Console.

It might be cleaner to use useReducer / useContext instead of Redux in this case (see https://reactjs.org/docs/hooks-faq.html#how-to-avoid-passing-callbacks-down). (Maybe the admin perspective should too.)

Not entirely sure what the follow up point was here @kyoto -- if we wanted to persist it?

[andrewballantyne]

/retest

[kyoto]

Not entirely sure what the follow up point was here @kyoto -- if we wanted to persist it?

I think we should not persist it, especially since the change would persist between Dev and Admin Consoles. It would probably be confusing UX.

To be clear, there is no need to change the Admin Console code as part of this PR. I'm just thinking that this Dev Console change should not persist in redux after you leave the page.

[andrewballantyne]

/retest

[jerolimov]

Tested with Firefox (which has this image drag and drop issue but two clicks works fine) and Chrome. Sets the custom time range and works as expected 👍

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andrewballantyne, jerolimov, vikram-raj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• frontend/packages/dev-console/OWNERS [andrewballantyne,jerolimov]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@vikram-raj: All pull requests linked via external trackers have merged:

• openshift/console#9314

Bugzilla bug 1972011 has been moved to the MODIFIED state.

In response to this:

Bug 1972011: Fix time range for drag & drop in devconsole monitoring

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.