Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1973572: Hardcode strings in Home->Overview page #9322

Merged
merged 1 commit into from Jun 25, 2021
Merged

Bug 1973572: Hardcode strings in Home->Overview page #9322

merged 1 commit into from Jun 25, 2021

Conversation

kdoberst
Copy link
Contributor

This addresses Bug 1973572

The following add changes for the following:

  • Control Plane
  • Configure
  • Cluster
  • Not available

to ensure that they are provided the translated value when language is set to simple Chinese.

Note: These changes have all been made in 4.8. This commit to to bring those changes into 4.7.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 22, 2021

@kdoberst: This pull request references Bugzilla bug 1973572, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

8 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.z) matches configured target release for branch (4.7.z)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1924586 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
  • dependent bug Bugzilla bug 1927465 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
  • dependent Bugzilla bug 1924586 targets the "4.8.0" release, which is one of the valid target releases: 4.8.0
  • dependent Bugzilla bug 1927465 targets the "4.8.0" release, which is one of the valid target releases: 4.8.0
  • bug has dependents

Requesting review from QA contact:
/cc @yapei

In response to this:

Bug 1973572: Hardcode strings in Home->Overview page

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Jun 22, 2021
@openshift-ci openshift-ci bot requested review from yapei, spadgett and tisnik June 22, 2021 19:49
@openshift-ci openshift-ci bot added component/core Related to console core functionality component/insights Related to insights plugin kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated labels Jun 22, 2021
@spadgett spadgett added this to the v4.7.z milestone Jun 23, 2021
spadgett
spadgett approved these changes Jun 23, 2021
View reviewed changes
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 23, 2021
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@kdoberst
Copy link
Contributor Author

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 23, 2021
@kdoberst
Add i18n for overview page
7abc01f 
The following add changes for the following:
- Control Plane
- Configure
- Cluster
- Not available

Note: These changes have all been made in 4.8. This commit to to bring those changes into 4.7.
@kdoberst kdoberst force-pushed the Bug-1973572-Hardcode-strings-in-overview-page branch from b29b047 to 7abc01f Compare June 24, 2021 19:46
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jun 24, 2021
@kdoberst
Copy link
Contributor Author

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 25, 2021
@kdoberst
Copy link
Contributor Author

@spadgett Sorry Sam - I had remove some comments that caused the localization files to not be build correctly and the test failed. I added them back in and now all the tests pass. Can you give this another look? (See frontend/packages/console-app/src/plugin.tsx)

spadgett
spadgett approved these changes Jun 25, 2021
View reviewed changes
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 25, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 25, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kdoberst, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@bparees bparees added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jun 25, 2021
@openshift-merge-robot openshift-merge-robot merged commit b571ac9 into openshift:release-4.7 Jun 25, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 25, 2021

@kdoberst: All pull requests linked via external trackers have merged:

Bugzilla bug 1973572 has been moved to the MODIFIED state.

In response to this:

Bug 1973572: Hardcode strings in Home->Overview page

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spadgett spadgett spadgett approved these changes

@yapei yapei Awaiting requested review from yapei

@tisnik tisnik Awaiting requested review from tisnik

Assignees

@spadgett spadgett

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. component/core Related to console core functionality component/insights Related to insights plugin kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
v4.7.z
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@kdoberst @openshift-bot @spadgett @bparees @openshift-merge-robot