New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1970011: Fix edge case for "managed by" links #9323
Conversation
@TheRealJon: This pull request references Bugzilla bug 1973524, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: TheRealJon The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
In the 'managed by' link components and helpers, account for the edge case where a resource has a CSV as an ownerReference.
@TheRealJon: This pull request references Bugzilla bug 1973524, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/bugzilla refresh |
@TheRealJon: This pull request references Bugzilla bug 1973524, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Version shouldn't matter. It's the same resource if the group and kind match regardless of API version. |
I'll just remove this change since it doesn't specifically address this bug. |
@TheRealJon: This pull request references Bugzilla bug 1973524, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@TheRealJon: This pull request references Bugzilla bug 1970011, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@TheRealJon: This pull request references Bugzilla bug 1970011. The bug has been updated to no longer refer to the pull request using the external bug tracker. All external bug links have been closed. The bug has been moved to the NEW state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Opened #9331 instead (target branch in this PR was not named correctly) |
In the 'managed by' link components and helpers, account for the edge case where a resource has a CSV as an ownerReference.
isOwnedByCSV
helper to only return true when the CSVgroup~version~kind
and name match the owner reference. This was the source of the bug. Previously, the match criteria was too broad and was causingmatchOwnerAndCSV
to return a false match.ManagedByOperatorResourceLink
to only add the ownerReferencegroup~version~kind
and name to the link URL if it is not a CSV.