Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1970011: Fix edge case for "managed by" links #9323

Closed
wants to merge 1 commit into from

Conversation

TheRealJon
Copy link
Member

@TheRealJon TheRealJon commented Jun 22, 2021

In the 'managed by' link components and helpers, account for the edge case where a resource has a CSV as an ownerReference.

  • Update isOwnedByCSV helper to only return true when the CSV group~version~kind and name match the owner reference. This was the source of the bug. Previously, the match criteria was too broad and was causing matchOwnerAndCSV to return a false match.
  • Update ManagedByOperatorResourceLink to only add the ownerReference group~version~kind and name to the link URL if it is not a CSV.

@openshift-ci openshift-ci bot added the bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. label Jun 22, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 22, 2021

@TheRealJon: This pull request references Bugzilla bug 1973524, which is invalid:

  • expected the bug to target the "4.9.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1973524: Fix edge case for "managed by" links

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Jun 22, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 22, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: TheRealJon
To complete the pull request process, please assign spadgett after the PR has been reviewed.
You can assign the PR to them by writing /assign @spadgett in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the component/core Related to console core functionality label Jun 22, 2021
In the 'managed by' link components and helpers, account for the edge case where a resource has a CSV as an ownerReference.
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 22, 2021

@TheRealJon: This pull request references Bugzilla bug 1973524, which is invalid:

  • expected the bug to target the "4.9.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1973524: Fix edge case for "managed by" links

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@TheRealJon
Copy link
Member Author

/bugzilla refresh

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 22, 2021

@TheRealJon: This pull request references Bugzilla bug 1973524, which is invalid:

  • expected the bug to target the "4.9.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett
Copy link
Member

  • Update isOwnedByOperator helper to only return true when a CRD has a full group~version~kind match with the owner (this is not strictly a fix for this bug, but could have caused other issues where an ownerReference might have matched on an incorrect API version)

Version shouldn't matter. It's the same resource if the group and kind match regardless of API version.

@TheRealJon
Copy link
Member Author

Version shouldn't matter. It's the same resource if the group and kind match regardless of API version.

I'll just remove this change since it doesn't specifically address this bug.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 23, 2021

@TheRealJon: This pull request references Bugzilla bug 1973524, which is invalid:

  • expected the bug to target the "4.9.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1973524: Fix edge case for "managed by" links

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@TheRealJon TheRealJon changed the title Bug 1973524: Fix edge case for "managed by" links Bug 1970011: Fix edge case for "managed by" links Jun 23, 2021
@openshift-ci openshift-ci bot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jun 23, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 23, 2021

@TheRealJon: This pull request references Bugzilla bug 1970011, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.9.0) matches configured target release for branch (4.9.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @yapei

In response to this:

Bug 1970011: Fix edge case for "managed by" links

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Jun 23, 2021
@openshift-ci openshift-ci bot requested a review from yapei June 23, 2021 14:53
@TheRealJon TheRealJon closed this Jun 23, 2021
@TheRealJon TheRealJon deleted the 1973524 branch June 23, 2021 15:04
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 23, 2021

@TheRealJon: This pull request references Bugzilla bug 1970011. The bug has been updated to no longer refer to the pull request using the external bug tracker. All external bug links have been closed. The bug has been moved to the NEW state.

In response to this:

Bug 1970011: Fix edge case for "managed by" links

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@TheRealJon
Copy link
Member Author

Opened #9331 instead (target branch in this PR was not named correctly)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/core Related to console core functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants