Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1975696: compareOwnerReference should not accept a reference #9336

Merged
merged 1 commit into from Jun 26, 2021
Merged

Bug 1975696: compareOwnerReference should not accept a reference #9336

merged 1 commit into from Jun 26, 2021

Conversation

glekner
Copy link
Contributor

@glekner glekner commented Jun 24, 2021

@openshift-ci openshift-ci bot added the bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. label Jun 24, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 24, 2021

@glekner: This pull request references Bugzilla bug 1975696, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.9.0) matches configured target release for branch (4.9.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @gouyang

In response to this:

Bug 1975696: compareOwnerReference should not accept a reference

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jun 24, 2021
@openshift-ci openshift-ci bot added component/kubevirt Related to kubevirt-plugin component/shared Related to console-shared labels Jun 24, 2021
spadgett
spadgett requested changes Jun 24, 2021
View reviewed changes
frontend/packages/kubevirt-plugin/src/k8s/wrapper/vm/combined-disk.ts Outdated
@@ -343,7 +340,7 @@ export class CombinedDiskFactory {
(getOwnerReferences(p) || []).some((ownerReference) =>
compareOwnerReference(ownerReference, {
name: dataVolumeName,
kind: kubevirtReferenceForModel(DataVolumeModel),
kind: DataVolumeModel,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be...?

Suggested change
kind: DataVolumeModel,
kind: DataVolumeModel.kind,

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops

@glekner
Copy link
Contributor Author

glekner commented Jun 24, 2021

/retest

spadgett
spadgett approved these changes Jun 25, 2021
View reviewed changes
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 25, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 25, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: glekner, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 25, 2021
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 449d8d9 into openshift:master Jun 26, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 26, 2021

@glekner: All pull requests linked via external trackers have merged:

Bugzilla bug 1975696 has been moved to the MODIFIED state.

In response to this:

Bug 1975696: compareOwnerReference should not accept a reference

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett spadgett added this to the v4.9 milestone Jul 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spadgett spadgett spadgett approved these changes

@gouyang gouyang Awaiting requested review from gouyang

@TheRealJon TheRealJon Awaiting requested review from TheRealJon

@yaacov yaacov Awaiting requested review from yaacov

Assignees

@spadgett spadgett

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/kubevirt Related to kubevirt-plugin component/shared Related to console-shared lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
v4.9
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@glekner @openshift-bot @spadgett @openshift-merge-robot