Fix accessibility issue in Quick starts page-Buttons must have discernible text

[sanketpathak]

Fixes:
https://issues.redhat.com/browse/ODC-6065

Analysis / Root cause:
Getting Critical Accessibility violation when scaning the Quick Starts page using axe tool

Solution Description:
Added aria-label to the prerequisite button on quick start tile

Screen shots / Gifs for design review:
UI is unchanged
Before:

After:

Unit test coverage report:
Unchanged

Test setup:
Go to Quick Starts catalog page and scan page using axe devtools in developer console

Browser conformance:

• Chrome
• Firefox
• Safari
• Edge

[spadgett]

If this page now passes axe, can we add it to the pages we test a11y for in cypress? If not, how hard is it to address the remaining issue?

The easiest way to add a11y test coverage is to add this page to the other routes test here:

https://github.com/spadgett/console/blob/852743d807b0c5f8a551cb4bc18345b8c3b22029/frontend/packages/integration-tests-cypress/tests/crud/other-routes.spec.ts#L125

[christianvogt]

Imagine a screen reader telling you that you've navigated to a button and then it tells you "Prerequisites icon". Do you know what the button does now?

An aria-label is just as important as visible text. Button text should be actionable.

Suggested change

	aria-label={t('quickstart~Prerequisites icon')}
	aria-label={t('quickstart~Show prerequisites')}

Don't forget to regenerate the locale files.

[sanketpathak]

Thanks for explaining, I've updated the pr

[christianvogt]

/retest

[christianvogt]

fyi @jschuler

[sanketpathak]

@spadgett Critical issues from the Quick Starts catalog page has been removed by this pr and I can see one moderate issue remaining

[christianvogt]

/lgtm
/approved

I think we can further improve this with other aria attributes to indicate a popup but for now this addresses the immediate concern.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christianvogt, sanketpathak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• frontend/OWNERS [christianvogt]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment