Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: improve README #9348

Merged
merged 1 commit into from Jun 28, 2021
Merged

docs: improve README #9348

merged 1 commit into from Jun 28, 2021

Conversation

rkpattnaik780
Copy link
Contributor

fixes typos in README doc

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 26, 2021

Hi @rkpattnaik780. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 26, 2021
@openshift-ci openshift-ci bot requested review from jhadvig and spadgett June 26, 2021 19:34
@kyoto
Copy link
Member

kyoto commented Jun 28, 2021

/lgtm
Thanks!

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 28, 2021
@rkpattnaik780
Copy link
Contributor Author

/assign @bparees

bparees
bparees reviewed Jun 28, 2021
View reviewed changes
README.md Outdated
@@ -282,7 +282,7 @@ yarn run webdriver-update-macos

##### Hacking Protractor Tests

To see what the tests are actually doing, it is posible to run in none `headless` mode by setting the `NO_HEADLESS` environment variable:
To see what the tests are actually doing, it is possible to run in none `headless` mode by setting the `NO_HEADLESS` environment variable:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
To see what the tests are actually doing, it is possible to run in none `headless` mode by setting the `NO_HEADLESS` environment variable:
To see what the tests are actually doing, it is possible to run in non-`headless` mode by setting the `NO_HEADLESS` environment variable:

@bparees
Copy link

bparees commented Jun 28, 2021

@rkpattnaik780 suggested one more fix while you're in here anyway, if you don't mind.

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. lgtm Indicates that a PR is ready to be merged. labels Jun 28, 2021
@bparees
Copy link

bparees commented Jun 28, 2021

/lgtm

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 28, 2021
@bparees
Copy link

bparees commented Jun 28, 2021

/hold

@rkpattnaik780 can you squash your commits?

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 28, 2021
@rkpattnaik780
docs: improve README
2961536 
fixes typos in README doc
@rkpattnaik780
Copy link
Contributor Author

/hold

@rkpattnaik780 can you squash your commits?

Squshed!

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jun 28, 2021
@bparees
Copy link

bparees commented Jun 28, 2021

thank you!

/hold cancel
/lgtm

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Jun 28, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 28, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bparees, kyoto, rkpattnaik780

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 8dadb16 into openshift:master Jun 28, 2021
@spadgett spadgett added this to the v4.9 milestone Jul 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhadvig jhadvig Awaiting requested review from jhadvig

@spadgett spadgett Awaiting requested review from spadgett

@bparees bparees Awaiting requested review from bparees

Assignees

@kyoto kyoto

@bparees bparees

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.
Projects
None yet
Milestone
v4.9
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@rkpattnaik780 @kyoto @bparees @spadgett @openshift-merge-robot