Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CPU Usage query in dev console monitoring #9358

Merged
merged 2 commits into from Jun 30, 2021

Conversation

vikram-raj
Copy link
Member

Fixes:
https://issues.redhat.com/browse/ODC-6075

Analysis / Root cause:
The query for CPU Usage has been changed.

Solution Description:
Replace sum_rate with sum_irate in the CPU usage query.

Screen shots / Gifs for design review:
image

@openshift-ci openshift-ci bot added the component/dev-console Related to dev-console label Jun 28, 2021
@spadgett
Copy link
Member

@TheRealJon I suspect the admin console has the same issue

@invincibleJai
Copy link
Member

/approve

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 29, 2021
@TheRealJon
Copy link
Member

@TheRealJon I suspect the admin console has the same issue

@spadgett Yeah, I basically copied this query from dev console, so it's probably affecting us too. Should we open a separate PR for this, or just go ahead and have @vikram-raj update our query in this PR?

@vikram-raj
Copy link
Member Author

@TheRealJon I will update that query in this PR.

@vikram-raj
Copy link
Member Author

@TheRealJon @spadgett Updated the query in the admin console as well.

@jerolimov
Copy link
Member

jerolimov commented Jun 29, 2021

What are the pre-conditions for this?

I started a cluster with launch openshift/console#9358, created a Pod which consumes some CPU but could not see any datapoints for sum_irate -- sum_rate still works.

Cluster was based on 4.8.0-0.ci.test-2021-06-29-215834. Is a 4.9 cluster required for this change?

Peek 2021-06-30 01-40

@jerolimov
Copy link
Member

/assign

@vikram-raj
Copy link
Member Author

@jerolimov This change is in 4.9. Up to 4.8 sum_rate works as expected.

@jerolimov
Copy link
Member

Thanks @vikram-raj

Verified it now on 4.9.0-0.nightly-2021-06-29-114024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 30, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 30, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: invincibleJai, jerolimov, vikram-raj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 5c69060 into openshift:master Jun 30, 2021
@vikram-raj vikram-raj deleted the odc-6075 branch June 30, 2021 14:18
@spadgett spadgett added this to the v4.9 milestone Jul 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/dev-console Related to dev-console component/shared Related to console-shared lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants