New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove usage of digest from helm catalog item uid #9364
Conversation
/kind bug |
@@ -107,7 +98,7 @@ export const normalizeHelmCharts = ( | |||
]; | |||
|
|||
const helmChart = { | |||
uid: `${chartRepoName}--${digest}`, | |||
uid: `${name}--${version}`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will not be unique when same chart is coming from two different chart repositories. I think we need to use chart URLs to make it always unique. Check #tmp-odc-helm
channel on slack for related conversation around this.
@@ -107,7 +98,7 @@ export const normalizeHelmCharts = ( | |||
]; | |||
|
|||
const helmChart = { | |||
uid: `${chartRepoName}--${digest}`, | |||
uid: `${chartURL}`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This might clash again since the same chart can come from multiple chart repositories.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about if we go with name + randomString
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be good enough.
uid: `${chartURL}`, | |
uid: `${chartRepoName}--${chartURL}`, |
@@ -107,7 +98,7 @@ export const normalizeHelmCharts = ( | |||
]; | |||
|
|||
const helmChart = { | |||
uid: `${chartRepoName}--${digest}`, | |||
uid: `${chartURL}`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be good enough.
uid: `${chartURL}`, | |
uid: `${chartRepoName}--${chartURL}`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: debsmita1, rohitkrai03 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fixes:
https://issues.redhat.com/browse/ODC-6077
Root analysis:
digest
is an optional property and theuid
of helm chart depends on the digest's value. As a result, charts with nodigest
property will have the uid as<provider-name>--undefined
so all the charts that belong to the same provider will have the same uid and the last one in the lot is considered.Solution description:
Screenshots:
Before
After
Test setup: