cnv-8975: Enable online VM snapshots in the UI #9367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Aviv Turgeman <aturgema@redhat.com>
openshift-ci
bot
added
component/kubevirt
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: avivtur, yaacov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
lgtm
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@matthewcarleton please review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes:
https://issues.redhat.com/browse/CNV-8975
Analysis / Root cause:
Restrictions for creating snapshot while VM is running
Solution Description:
Removing restrictions for snapshot while VM is running, adjusting the 'snapshot' modal and list of snapshot in snapshot page UI components accordingly to indicate about snapshot creation while VM is running
Screen shots / Gifs for design review:
before:
after:
snapshot creation while VM is still on running status:
created snapshot yaml file:
snapshot restore demo:
Signed-off-by: Aviv Turgeman aturgema@redhat.com