Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update class names for terminal to avoid clash with markdown code styles #9370

Merged
merged 1 commit into from
Jun 29, 2021
Merged

Update class names for terminal to avoid clash with markdown code styles #9370

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 4 additions & 4 deletions frontend/public/components/_terminal.scss
View file
Open in desktop
Expand Up @@ -3,17 +3,17 @@
$console-z-index: $zindex-navbar-fixed + 20;
$console-collapse-link-z-index: $console-z-index + 20;

.console > .terminal {
.co-terminal > .terminal {
color: $color-pf-white;
padding: 10px;
background-color: $color-pf-black;
}

.console > .terminal.fullscreen {
.co-terminal > .terminal.fullscreen {
z-index: $console-z-index; // in fullscreen mode, to get above $zindex-navbar-fixed
}

.console {
.co-terminal {
width: 100%;
height: 100%;
padding: 0;
Expand All @@ -24,7 +24,7 @@ $console-collapse-link-z-index: $console-z-index + 20;
}
}

.console-collapse-link.pf-c-button {
.co-terminal-collapse-link.pf-c-button {
background: rgba(0, 0, 0, 0.75) !important;
color: $color-pf-blue-300;
position: fixed;
Expand Down
4 changes: 2 additions & 2 deletions frontend/public/components/terminal.jsx
View file
Open in desktop
Expand Up @@ -123,10 +123,10 @@ class Terminal_ extends React.Component {
const { t } = this.props;
return (
<div ref={this.outerRef} style={this.state} className={this.props.className}>
<div ref={this.innerRef} className="console">
<div ref={this.innerRef} className="co-terminal">
{this.isFullscreen && (
<Button
className="console-collapse-link"
className="co-terminal-collapse-link"
onClick={() => this.setFullscreen(false)}
variant="link"
>
Expand Down