Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show selected namespace in the Add page links #9374

Merged
merged 1 commit into from Jun 30, 2021
Merged

Show selected namespace in the Add page links #9374

merged 1 commit into from Jun 30, 2021

Conversation

debsmita1
Copy link
Contributor

Fixes:
https://issues.redhat.com/browse/ODC-6031

Root analysis:
if the href doesn't contain :namespace then it uses the active namespace

Solution description:
Added /ns/:namespace in the href

GIF:
Peek 2021-06-29 20-28

Test coverage:
Screenshot from 2021-06-29 22-30-19

@openshift-ci openshift-ci bot added component/helm Related to helm-plugin component/knative Related to knative-plugin labels Jun 29, 2021
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 29, 2021
@debsmita1
Copy link
Contributor Author

/cc @jerolimov

@openshift-ci openshift-ci bot requested a review from jerolimov June 30, 2021 05:17
jerolimov
jerolimov approved these changes Jun 30, 2021
View reviewed changes
Copy link
Member

@jerolimov jerolimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 30, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andrewballantyne, debsmita1, jerolimov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 30, 2021
@openshift-merge-robot openshift-merge-robot merged commit 0dfb280 into openshift:master Jun 30, 2021
@debsmita1
Copy link
Contributor Author

/kind bug

@openshift-ci openshift-ci bot added the kind/bug Categorizes issue or PR as related to a bug. label Jul 1, 2021
@spadgett spadgett added this to the v4.9 milestone Jul 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jerolimov jerolimov jerolimov approved these changes

@andrewballantyne andrewballantyne andrewballantyne approved these changes

@christianvogt christianvogt Awaiting requested review from christianvogt

Assignees

@jerolimov jerolimov

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/dev-console Related to dev-console component/helm Related to helm-plugin component/knative Related to knative-plugin kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
v4.9
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@debsmita1 @jerolimov @andrewballantyne @spadgett @openshift-merge-robot