Cypress: Updated isPseudoLocalized() to correctly process multiple elements #9385
Conversation
openshift-ci
bot
added
component/core
| cy.wrap(subject).each(($el) => { | ||
| const text = $el.text(); | ||
| if (text.length > 0) { | ||
| expect(text).to.match(/\[[^a-zA-Z]+\]/); | ||
| } | ||
| }); |
There was a problem hiding this comment.
tested this change locally, nice!
| cy.byTestID('application-launcher-item').isPseudoLocalized(); | ||
| // wait for both console help menu items and additionalHelpActions items to load | ||
| // additionalHelpActions come from ConsoleLinks 'HelpMenu' yaml and are not translated | ||
| cy.get('.pf-c-app-launcher__group').should('have.length', 2); |
There was a problem hiding this comment.
We should open a Bugzilla for the menu items not translated. I think it would be better to move this into console so they can be translated instead of leaving them as ConsoleLink resources, although it will require some operator changes.
There was a problem hiding this comment.
dtaylor113
force-pushed
the
cypress-i18n-tests
branch
from
3fdd2bf
to
9c930b7
Compare
|
apologies @rebeccaalpert, looks like I didn't push the fixes :-) Should be updated now. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dtaylor113, rebeccaalpert, rhamilto The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Previously a call such as:
cy.byTestID('nav').isPseudoLocalized();would incorrectly result in one call to
isPseudoLocalized()which would test a single combined text string consisting of all of the text of matching elements! In this example "[Ḥṓṓṃḛḛ] [ṎṎṽḛḛṛṽḭḭḛḛẁ] [Ṕṛṓṓĵḛḛͼţṡ]...[ṎṎṗḛḛṛααţṓṓṛṡ] [Ḉṓṓṃṗṵṵţḛḛ]..." -instead of testing each element text individually. So,isPseudoLocalized()would pass as long as first and last elements were translated.Updated
isPseudoLocalized()to correctly process multiple elements, as well as:pseudolocalization.spec.tsto correctly test masthead Help menu items and Overview dashboard 'Cluster utilization' card.data-testids