[release-4.6] Bug 1978159: update cluster-local label for ksvc

[openshift-cherrypick-robot]

This is an automated cherry-pick of #9220

/assign invincibleJai

[openshift-ci]

@openshift-cherrypick-robot: Bugzilla bug 1970796 has been cloned as Bugzilla bug 1978159. Retitling PR to link against new bug.
/retitle [release-4.6] [release-4.7] Bug 1978159: update cluster-local label for ksvc

In response to this:

[release-4.6] [release-4.7] Bug 1970796: update cluster-local label for ksvc

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1978159, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.6.z) matches configured target release for branch (4.6.z)
• bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
• dependent bug Bugzilla bug 1970796 is in the state CLOSED (ERRATA), which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
• dependent Bugzilla bug 1970796 targets the "4.7.z" release, which is one of the valid target releases: 4.7.0, 4.7.z
• bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (msaud@redhat.com), skipping review request.

In response to this:

[release-4.6] [release-4.7] Bug 1978159: update cluster-local label for ksvc

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jerolimov]

/retitle [release-4.6] Bug 1978159: update cluster-local label for ksvc

[jerolimov]

Tested it on a cluster started launch openshift/console#9389 (4.6.0-0.ci.test-2021-07-03-093033-ci-ln-xd5hj8k-latest)

Label is set correct as documented also in the 4.6 doc https://docs.openshift.com/container-platform/4.6/serverless/networking/serverless-ossm-custom-domains.html#knative-service-cluster-local_serverless-ossm-custom-domains

@invincibleJai Should we support older operators as well which doesn't know this label?

/lgtm

[invincibleJai]

Tested it on a cluster started launch openshift/console#9389 (4.6.0-0.ci.test-2021-07-03-093033-ci-ln-xd5hj8k-latest)

Label is set correct as documented also in the 4.6 doc https://docs.openshift.com/container-platform/4.6/serverless/networking/serverless-ossm-custom-domains.html#knative-service-cluster-local_serverless-ossm-custom-domains

@invincibleJai Should we support older operators as well which doesn't know this label?

/lgtm

Thanks Christoph, we need to support what's in the documentation for 4.6 https://docs.openshift.com/container-platform/4.6/serverless/networking/serverless-ossm-custom-domains.html#knative-service-cluster-local_serverless-ossm-custom-domains as highlighted by you and the same has been requested by the Serverless team.

[invincibleJai]

/cc @rohitkrai03

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andrewballantyne, jerolimov, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• frontend/packages/dev-console/OWNERS [andrewballantyne]
• frontend/packages/knative-plugin/OWNERS [andrewballantyne]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged:

• openshift/console#9389

Bugzilla bug 1978159 has been moved to the MODIFIED state.

In response to this:

[release-4.6] Bug 1978159: update cluster-local label for ksvc

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.