Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an Extension for ODF #9392

Closed
wants to merge 1 commit into from
Closed

Conversation

bipuladh
Copy link
Contributor

@bipuladh bipuladh commented Jul 1, 2021

ODF is an integration plane for 3rd party storage vendors. 3rd part vendors should be able to inject dashboards.

export type ODFPluginDashboard = ExtensionDeclaration<
  'odf.plugin/dashboard',
  {
    /** The model for which this dashboard is related to */
    model: ExtensionK8sModel;
    component: CodeRef<React.ComponentType<ODFDashboardProps>>;
  }
>;

Ex: An IBM Storage provider will inject its dashboard rather than overwriting a route. This should make things easier for third-party vendors.
This PR also exposes useResolvedExtensions as part of the SDK.
It depends on #9230
Please review the latest commit.
/assign @vojtechszocs @christianvogt

@openshift-ci openshift-ci bot added component/dashboard Related to dashboard component/sdk Related to console-plugin-sdk component/shared Related to console-shared labels Jul 1, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 26, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bipuladh
To complete the pull request process, please ask for approval from christianvogt after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@bipuladh bipuladh closed this Sep 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/dashboard Related to dashboard component/sdk Related to console-plugin-sdk component/shared Related to console-shared
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants