Rename monitoring tab to Observe

[vikram-raj]

Fixes:
https://issues.redhat.com/browse/ODC-6088

Description:
Rename monitoring tab and nav option to Observe

Screen shots / Gifs for design review:

Browser conformance:

• Chrome
• Firefox
• Safari
• Edge

[vikram-raj]

/cc @kyoto

[vikram-raj]

/cc @invincibleJai

[spadgett]

Won't this break users' bookmarks?

[kyoto]

Thanks @spadgett

I guess we should leave the URLs unchanged and just change the text?

[vikram-raj]

Yes, users will get the 404 not found page if they have bookmarked the monitoring URL. But @serenamarie125 is fine with this change.

[vikram-raj]

/test e2e-gcp-console

[abhinandan13jan]

should we not update the quickstart ids?

[abhinandan13jan]

@vikram-raj correct me if wrong, I see we need updated QuickStart for monitoring-sample-app in the console-operator repo
and in integration test, global.ts do we need to update the following?

export enum devNavigationMenu {
  Add = '+Add',
  Topology = 'Topology',
  Monitoring = 'Monitoring',
  Builds = 'Builds',
  Search = 'Search',
  Helm = 'Helm',
  Project = 'Project',
  ProjectAccess = 'Project Access',
  Pipelines = 'Pipelines',
  ConfigMaps = 'Config Maps',
  Secrets = 'Secrets',
  GitOps = 'GitOps',
  Environments = 'Environments',
}

[abhinandan13jan]

Ran locally, runs fine

[vikram-raj]

@vikram-raj correct me if wrong, I see we need updated QuickStart for monitoring-sample-app in the console-operator repo
and in integration test, global.ts do we need to update the following?

export enum devNavigationMenu {
  Add = '+Add',
  Topology = 'Topology',
  Monitoring = 'Monitoring',
  Builds = 'Builds',
  Search = 'Search',
  Helm = 'Helm',
  Project = 'Project',
  ProjectAccess = 'Project Access',
  Pipelines = 'Pipelines',
  ConfigMaps = 'Config Maps',
  Secrets = 'Secrets',
  GitOps = 'GitOps',
  Environments = 'Environments',
}

Thanks @abhinandan13jan , yes we need to update the qucikstarts for the monitoring as well. I will open a PR.

[spadgett]

Yes, users will get the 404 not found page if they have bookmarked the monitoring URL.

I dislike breaking links if we can avoid it. Is it possible to add a react router redirect? (I don't think this would work for tabs, though).

The URL content itself is not that important. Few users look at it, and many browsers even hide the path these days. It's more important that the URLs are stable IMO. Have we considered updating the labels in the UI and leaving the URLs as they are?

[serenamarie125]

Having a redirect would be my preference if possible. If not possible, keeping the URLs as monitoring works.

[kyoto]

My concern is that if we change the UI wording again in the future or reorganize the sidebar, we could then be looking at changing the URLs again and adding another redirect. So it seems easier to leave the URLs as is.

The current monitoring in the URLs seems like a logical choice to me, even if the UI wording differs.

[vikram-raj]

Updated the text in quickstart.
Here is the PR openshift/console-operator#563

[kyoto]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kyoto, vikram-raj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• frontend/OWNERS [kyoto]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment