Removes Pipeline Graph alignment setting #9425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
component/pipelines
|
Verified locally, looks good to me. Adding hold, so it doesn't get merged before @bgliwa01 looks at the changes. |
openshift-ci
bot
added
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andrewballantyne, karthikjeeyar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes:
https://issues.redhat.com/browse/ODC-5100
Analysis / Root cause:
Our current layout algorithm for Pipeline Topology is called Dagre. Dagre lays out our graph in such a fashion that goes from one side to another (in our case left to right). The problem we had was it was built to try and mimic the previous column-layout which in itself had several layout problems (couldn't do complex graphs).
Solution Description:
Removed the 'top left' alignment from the Dagre layout in order to go with a more middle-vertical alignment. This doesn't "solve" all the problems, but it makes it more balanced.
There are still several issues with the layout, and after trying to tweak them, I am fairly confident there is little we can do with our current Dagre layout and not get into a wack-a-mole of problem solving layout issues.
Screenshots at the bottom as they are many.
Unit test coverage report:
None, we don't have tests for Dagre layouts. Although some though in this area probably wouldn't hurt (not sure of a clean deterministic way of testing).
Test setup:
Used these pipelines
Browser conformance:
Screenshots: