Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy versioned HCO for prow #9430

Merged

Conversation

yaacov
Copy link
Member

@yaacov yaacov commented Jul 7, 2021

Currently we use the development version of HCO for testing
We should use a versioned HCO install

@openshift-ci openshift-ci bot requested review from glekner and suomiy July 7, 2021 11:32
@openshift-ci openshift-ci bot added component/kubevirt Related to kubevirt-plugin approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 7, 2021
@yaacov
Copy link
Member Author

yaacov commented Jul 7, 2021

@pcbailey @glekner @avivtur @metalice please review

@yaacov yaacov force-pushed the deploy-versioned-hco-for-prow branch 4 times, most recently from 345ec93 to b573f3b Compare July 7, 2021 16:07
@glekner
Copy link
Contributor

glekner commented Jul 7, 2021

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 7, 2021
@yaacov yaacov force-pushed the deploy-versioned-hco-for-prow branch from b573f3b to a3428f2 Compare July 7, 2021 17:13
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 7, 2021
@glekner
Copy link
Contributor

glekner commented Jul 7, 2021

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 7, 2021
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 7, 2021
@yaacov
Copy link
Member Author

yaacov commented Jul 7, 2021

@pcbailey hi, I removed protractor tests that as duplications in cypress, please review

@pcbailey
Copy link
Contributor

pcbailey commented Jul 8, 2021

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 8, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 8, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: glekner, pcbailey, yaacov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit e2bd605 into openshift:master Jul 8, 2021
@spadgett spadgett added this to the v4.9 milestone Jul 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/kubevirt Related to kubevirt-plugin lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants