Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Monitoring dashboards: Add text filter to the Dashboards dropdown and the variable dropdowns #9431

Merged
merged 1 commit into from Aug 4, 2021
Merged

Monitoring dashboards: Add text filter to the Dashboards dropdown and the variable dropdowns #9431

merged 1 commit into from Aug 4, 2021

Conversation

kyoto
Copy link
Member

@kyoto kyoto commented Jul 7, 2021 •
edited

Jira ticket: https://issues.redhat.com/browse/MON-1521

Also moves TimespanDropdown to its own file since it no longer uses VariableDropdown.

screenshot

@openshift-ci openshift-ci bot added the component/core Related to console core functionality label Jul 7, 2021
@openshift-ci openshift-ci bot added component/dev-console Related to dev-console approved Indicates a PR has been approved by an approver from all required OWNERS files. component/monitoring Related to monitoring kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated labels Jul 7, 2021
@sichvoge
Copy link

sichvoge commented Jul 7, 2021

Does this work for the "Dashboards" drop down as well?

@kyoto
Copy link
Member Author

kyoto commented Jul 7, 2021

@sichvoge I hit a problem with the dashboards dropdown, so decided to leave that for a separate PR.

spadgett
spadgett approved these changes Jul 7, 2021
View reviewed changes
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/hold for approvals

frontend/public/components/monitoring/dashboards/index.tsx Show resolved Hide resolved
@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 7, 2021
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 7, 2021
@kyoto kyoto changed the title Monitoring dashboards: Add text filter to variable dropdowns [WIP] Monitoring dashboards: Add text filter to variable dropdowns Jul 16, 2021
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 16, 2021
@kyoto kyoto force-pushed the monitoring-dashboards-dropdown-filters branch from d0e3311 to 4f67260 Compare July 19, 2021 12:00
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 19, 2021
@kyoto
Copy link
Member Author

kyoto commented Jul 19, 2021

@spadgett I ended up extending and reworking this

  • Rebased
  • Addressed your feedback comment
  • Added the text filter for the Dashboards dropdown too
  • Refactored the isError case to also use a Select

@kyoto kyoto changed the title [WIP] Monitoring dashboards: Add text filter to variable dropdowns [WIP] Monitoring dashboards: Add text filter to the Dashboards dropdown and the variable dropdowns Jul 19, 2021
@kyoto kyoto force-pushed the monitoring-dashboards-dropdown-filters branch 2 times, most recently from 8982739 to d80010d Compare July 19, 2021 12:09
@Preeticp
Copy link

/label docs-approved

@openshift-ci openshift-ci bot added the docs-approved Signifies that Docs has signed off on this PR label Jul 21, 2021
@lihongyan1
Copy link

Filed bug
https://bugzilla.redhat.com/show_bug.cgi?id=1984365

@lihongyan1
Copy link

/label qe-approved
The bug is not critical and not very related to the PR

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Jul 27, 2021
spadgett
spadgett approved these changes Jul 28, 2021
View reviewed changes
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 28, 2021
@kyoto
Copy link
Member Author

kyoto commented Jul 28, 2021

/assign @sferich888
for px- approval

@sferich888
Copy link

/lables px-approved
/unassign @sferich888

@kyoto kyoto changed the title [WIP] Monitoring dashboards: Add text filter to the Dashboards dropdown and the variable dropdowns Monitoring dashboards: Add text filter to the Dashboards dropdown and the variable dropdowns Aug 2, 2021
@openshift-ci openshift-ci bot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Aug 2, 2021
@spadgett
Copy link
Member

spadgett commented Aug 2, 2021

/label px-approved
/hold cancel

@kyoto Needs rebase :/

@openshift-ci openshift-ci bot added px-approved Signifies that Product Support has signed off on this PR and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Aug 2, 2021
@kyoto
Monitoring dashboards: Add text filter to all dropdowns
98591d5 
Add text filter to the "Dashboards" dropdown and the variable dropdowns.
@kyoto kyoto force-pushed the monitoring-dashboards-dropdown-filters branch from d80010d to 98591d5 Compare August 3, 2021 12:12
@openshift-ci openshift-ci bot removed lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Aug 3, 2021
@kyoto
Copy link
Member Author

kyoto commented Aug 3, 2021

@spadgett Rebased

spadgett
spadgett approved these changes Aug 3, 2021
View reviewed changes
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 3, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 3, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kyoto, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot merged commit fa8d05a into openshift:master Aug 4, 2021
@kyoto kyoto deleted the monitoring-dashboards-dropdown-filters branch August 5, 2021 00:05
@spadgett spadgett added this to the v4.9 milestone Aug 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spadgett spadgett spadgett approved these changes

@invincibleJai invincibleJai Awaiting requested review from invincibleJai

@TheRealJon TheRealJon Awaiting requested review from TheRealJon

Assignees

@spadgett spadgett

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality component/dev-console Related to dev-console component/monitoring Related to monitoring docs-approved Signifies that Docs has signed off on this PR kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Milestone
v4.9
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@kyoto @sichvoge @Preeticp @lihongyan1 @sferich888 @spadgett