Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move ObjectEnum from console-shared to kubevirt #9444

Merged
merged 1 commit into from Jul 10, 2021
Merged

move ObjectEnum from console-shared to kubevirt #9444

merged 1 commit into from Jul 10, 2021

Conversation

glekner
Copy link
Contributor

@glekner glekner commented Jul 8, 2021

No description provided.

@openshift-ci openshift-ci bot requested review from jelkosz and spadgett July 8, 2021 12:56
@openshift-ci openshift-ci bot added component/kubevirt Related to kubevirt-plugin component/sdk Related to console-plugin-sdk labels Jul 8, 2021
@glekner
Copy link
Contributor Author

glekner commented Jul 8, 2021

@spadgett @vojtechszocs @christianvogt please review

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 8, 2021
@christianvogt
Copy link
Contributor

@glekner I don't think this is a valid API for the console plugin SDK to expose. It is a utility to help with enums but it doesn't help the plugin developer to build plugins.

I suggest copying the code to your repo.

We want to expose API that are required to build plugins, help them work with k8s APIs, and build a consistent user interface.

@glekner glekner changed the title move ObjectEnum from console-shared to dynamic plugin sdk move ObjectEnum from console-shared to kubevirt Jul 8, 2021
@glekner
Copy link
Contributor Author

glekner commented Jul 8, 2021

@christianvogt yep, moved the code into kubevirt

spadgett
spadgett approved these changes Jul 8, 2021
View reviewed changes
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/hold for others to look as well

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 8, 2021
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 8, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 8, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: glekner, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@christianvogt
Copy link
Contributor

/hold cancel

i'm fine with the move

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 9, 2021
@openshift-merge-robot openshift-merge-robot merged commit 012d0fc into openshift:master Jul 10, 2021
@spadgett spadgett added this to the v4.9 milestone Jul 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spadgett spadgett spadgett approved these changes

@jelkosz jelkosz Awaiting requested review from jelkosz

Assignees

@spadgett spadgett

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/kubevirt Related to kubevirt-plugin component/sdk Related to console-plugin-sdk lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
v4.9
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@glekner @christianvogt @spadgett @openshift-merge-robot