Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small changes and fixes for the advanced tab #9445

Merged

Conversation

metalice
Copy link
Contributor

@metalice metalice commented Jul 8, 2021

Signed-off-by: Matan Schatzman mschatzm@redhat.com

Fixes:
Small enhancements and fixes of the advanced tab

Screen shots / Gifs for design review:
After:
image
image

Before:
image

@openshift-ci openshift-ci bot requested review from glekner and pcbailey July 8, 2021 13:34
@openshift-ci openshift-ci bot added the component/kubevirt Related to kubevirt-plugin label Jul 8, 2021
@yaacov
Copy link
Member

yaacov commented Jul 8, 2021

/lgtm

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 8, 2021
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci openshift-ci bot added kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated and removed lgtm Indicates that a PR is ready to be merged. labels Jul 8, 2021
Signed-off-by: Matan Schatzman <mschatzm@redhat.com>
@yaacov
Copy link
Member

yaacov commented Jul 8, 2021

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 8, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 8, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: metalice, yaacov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit cb618e6 into openshift:master Jul 8, 2021
@spadgett spadgett added this to the v4.9 milestone Jul 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/kubevirt Related to kubevirt-plugin kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants