Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add compression savings to pool list page #9457

Merged
merged 1 commit into from Jul 24, 2021
Merged

Add compression savings to pool list page #9457

merged 1 commit into from Jul 24, 2021

Conversation

aruniiird
Copy link
Contributor

This PR is on top of @GowthamShanmugam 's PR#9252, just adding the compression savings details to the list page.

@openshift-ci openshift-ci bot requested review from afreen23 and jhadvig July 9, 2021 12:38
@openshift-ci openshift-ci bot added component/ceph Related to ceph-storage-plugin component/shared Related to console-shared kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated labels Jul 9, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 9, 2021

Hi @aruniiird. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 9, 2021
@aruniiird
Copy link
Contributor Author

@cloudbehl , @afreen23 , @bipuladh please take a look...

@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 18, 2021
@GowthamShanmugam
Copy link
Contributor

GowthamShanmugam commented Jul 18, 2021 •
edited

Please resolve conflicts and share some screen shot for this, Otherwise LGTM

afreen23
afreen23 suggested changes Jul 20, 2021
View reviewed changes
frontend/packages/ceph-storage-plugin/src/components/block-pool/block-pool-list-page.tsx Outdated
Comment on lines 123 to 124
const compressionSavings: string = humanizeBinaryBytes(props.poolCompressionSavings[name] || 0)
.string;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If there is no compression we should show a dash -. I dont think showing zero as default will be right for other states when there is a load error .

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right @afreen23 , updated the code...
@GowthamShanmugam , @afreen23 , screenshot attached, please take a look.

Screenshot from 2021-07-22 20-07-17

@aruniiird aruniiird force-pushed the add-compression-savings-to-pool-list-page branch from 63fa275 to debb1d4 Compare July 22, 2021 14:26
@openshift-ci openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 22, 2021
@aruniiird aruniiird force-pushed the add-compression-savings-to-pool-list-page branch from debb1d4 to 23a96a9 Compare July 23, 2021 08:46
@aruniiird
Copy link
Contributor Author

Rebased to latest upstream/master. @afreen23 , @GowthamShanmugam , please take a look

@GowthamShanmugam
Copy link
Contributor

/assign @cloudbehl

@GowthamShanmugam
Copy link
Contributor

Changes are fine, LGTM

afreen23
afreen23 approved these changes Jul 23, 2021
View reviewed changes
Copy link
Contributor

@afreen23 afreen23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jul 23, 2021
@aruniiird
Adding 'Compression Savings' details to the pool list page
054ffd2 
This is on top of Gowtham's PR#9252, adding the compression details into
the pool list page.

Signed-off-by: Arun Kumar Mohan <amohan@redhat.com>
@aruniiird aruniiird force-pushed the add-compression-savings-to-pool-list-page branch from 23a96a9 to 054ffd2 Compare July 24, 2021 10:23
@openshift-ci openshift-ci bot removed lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jul 24, 2021
@aruniiird
Copy link
Contributor Author

Rebased to latest upstream/master.

@afreen23
Copy link
Contributor

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 24, 2021
afreen23
afreen23 approved these changes Jul 24, 2021
View reviewed changes
Copy link
Contributor

@afreen23 afreen23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 24, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 24, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afreen23, aruniiird, GowthamShanmugam

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit de53fe1 into openshift:master Jul 24, 2021
@spadgett spadgett added this to the v4.9 milestone Aug 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GowthamShanmugam GowthamShanmugam GowthamShanmugam approved these changes

@afreen23 afreen23 afreen23 approved these changes

@jhadvig jhadvig Awaiting requested review from jhadvig

Assignees

@cloudbehl cloudbehl

@afreen23 afreen23

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/ceph Related to ceph-storage-plugin component/shared Related to console-shared kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.
Projects
None yet
Milestone
v4.9
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@aruniiird @GowthamShanmugam @afreen23 @spadgett @cloudbehl @openshift-merge-robot