Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1967047: Add new HealthState to signify an operator is upgradable in the cluster dashboard #9475

Merged

Conversation

jcaianirh
Copy link
Member

Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1967047

Added a new HealthState called upgradable which shows whether an operator has an upgrade available. The previous fix to this bug didn't change the health state which was pending (but the install wasn't pending). I played with using the existing warning state which is possible. I ended up creating this new upgradable state which shows the blue up arrow icon in the dashboard to show there is an upgrade available.

Screen Shot 2021-07-12 at 4 20 18 PM

cc: @openshift/team-ux-review

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 12, 2021

@jcaianirh: This pull request references Bugzilla bug 1967047, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.9.0) matches configured target release for branch (4.9.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @yanpzhan

In response to this:

Bug 1967047: Add new HealthState to signify an operator is upgradable in the cluster dashboard

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Jul 12, 2021
@openshift-ci openshift-ci bot added component/olm Related to OLM component/shared Related to console-shared kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated labels Jul 12, 2021
@itsptk
Copy link

itsptk commented Jul 13, 2021

@jcaianirh If a different operator is in a warning or error state, do those states take precedence in the "overall" status shown on the dashboard status card? This otherwise looks good to me.

Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 13, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 13, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcaianirh, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 13, 2021
@openshift-merge-robot openshift-merge-robot merged commit a9d5a54 into openshift:master Jul 13, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 13, 2021

@jcaianirh: All pull requests linked via external trackers have merged:

Bugzilla bug 1967047 has been moved to the MODIFIED state.

In response to this:

Bug 1967047: Add new HealthState to signify an operator is upgradable in the cluster dashboard

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett spadgett added this to the v4.9 milestone Jul 14, 2021
@jcaianirh
Copy link
Member Author

@jcaianirh If a different operator is in a warning or error state, do those states take precedence in the "overall" status shown on the dashboard status card? This otherwise looks good to me.

Yes, @itsptk the error states take precedence over the upgrade available. Here is a snapshot of that case where i have one manual subscription operator with an upgrade available, but also another operator with an error status.

Screen Shot 2021-07-14 at 2 58 19 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/dashboard Related to dashboard component/olm Related to OLM component/shared Related to console-shared kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants