New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1967047: Add new HealthState to signify an operator is upgradable in the cluster dashboard #9475
Bug 1967047: Add new HealthState to signify an operator is upgradable in the cluster dashboard #9475
Conversation
… in the dashboard
@jcaianirh: This pull request references Bugzilla bug 1967047, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@jcaianirh If a different operator is in a warning or error state, do those states take precedence in the "overall" status shown on the dashboard status card? This otherwise looks good to me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jcaianirh, spadgett The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@jcaianirh: All pull requests linked via external trackers have merged: Bugzilla bug 1967047 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Yes, @itsptk the error states take precedence over the upgrade available. Here is a snapshot of that case where i have one manual subscription operator with an upgrade available, but also another operator with an error status. |
Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1967047
Added a new HealthState called upgradable which shows whether an operator has an upgrade available. The previous fix to this bug didn't change the health state which was pending (but the install wasn't pending). I played with using the existing warning state which is possible. I ended up creating this new upgradable state which shows the blue up arrow icon in the dashboard to show there is an upgrade available.
cc: @openshift/team-ux-review