Move QuickSearch to Shared Package #9476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
do-not-merge/work-in-progress
openshift-ci
bot
added
component/shared
andrewballantyne
force-pushed
the
move-quick-search-to-shared
branch
from
fd9a940
to
fd687c6
Compare
openshift-ci
bot
added
the
kind/i18n
andrewballantyne
force-pushed
the
move-quick-search-to-shared
branch
from
fd687c6
to
5c91e95
Compare
| @@ -13,7 +13,6 @@ import QuickSearchContent from './QuickSearchContent'; | |||
| import { CatalogLinkData, QuickSearchData } from './utils/quick-search-types'; | |||
| import { handleCta } from './utils/quick-search-utils'; | |||
|
|
|||
| import './QuickSearchButton.scss'; | |||
There was a problem hiding this comment.
This was a mystery find lol... not sure why it existed.
frontend/packages/console-shared/locales/en/console-shared.json
Outdated
Show resolved
Hide resolved
andrewballantyne
force-pushed
the
move-quick-search-to-shared
branch
2 times, most recently
from
ca6b5ea
to
0a61df8
Compare
andrewballantyne
changed the title
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
/label docs-approved Not sure we need these labels as they won't apply to an internal code move. cc @makambalaji Need testing to make sure nothing in Topology Quick Search broke. /cc @divyanshiGupta /assign @karthikjeeyar I think I tagged everyone 😄 |
openshift-ci
bot
added
docs-approved
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
|
/retest |
openshift-ci
bot
added
the
needs-rebase
andrewballantyne
force-pushed
the
move-quick-search-to-shared
branch
from
0a61df8
to
22a98c8
Compare
openshift-ci
bot
removed
the
needs-rebase
|
Verified locally |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andrewballantyne, karthikjeeyar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/label qe-approved |
openshift-ci
bot
added
the
qe-approved
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
|
/kind feature |
openshift-ci
bot
added
the
kind/feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes:
https://issues.redhat.com/browse/ODC-6142
Description:
QuickSearch is too Topology centric. Needed to be moved to console/shared package so it can be used later in other places.
Browser conformance: