Bug 1982153: Skip empty categories (id and label) in OperatorHub tab view

[jerolimov]

Fixes:
https://issues.redhat.com/browse/ODC-6146
https://bugzilla.redhat.com/show_bug.cgi?id=1982153

Analysis / Root cause:
When running the cypress test developer-catalog-details.feature the test tries to install the OpenShift Serverless operator and fails because the OperatorHub page contains an accessibility issue.

The vertical tab navigation contains a VerticalTabsTab entry (li > a) (rendered in tile-view-page.jsx) which results in an anchor without accessibility infos:

<li class="vertical-tabs-pf-tab text-capitalize" data-test=""><a class="" href="#"></a></li>

(This may depend on the fetched OperatorHub data but happen on fresh clusters started with the cluster-bot.)

Solution Description:
The categories are calculated based on the OperatorHub items, some of them contains an empty category string ({ ... categories: [""] ... }). The new code just skips this empty category.

Screen shots / Gifs for design review:
@openshift/team-devconsole-ux

Skipping the empty string category results in a slightly different (IMHO fixed) UI:

Before there was a space between "All items" and the categories. There is no "Other" category because the entries are shown in this "empty string category.

On 4.6 it was also possible to select this category. Since 4.7 this is not possible anymore. But the "Other" entry is still missing.

With this PR the spacing (it was the empty string category) is not shown anymore. The page shows an "Other" entry instead at the end:

Unit test coverage report:
Added one new unit test for the util function which creates the category object:

 PASS  packages/operator-lifecycle-manager/src/components/operator-hub/operator-hub-items.spec.tsx (6.358s)
  determineCategories
    ✓ should merge categories by name (3ms)
    ✓ should sort categories by name (1ms)
    ✓ should not return categories if there is no defined
    ✓ should not return category if string is empty

Test setup:

• For an visual test just open the OperatorHub
• You can also verify the a11y issue with Firefox extension axe - Web Accessibility Testing
• To validate the cypress test run yarn test-cypress-devconsole and select developer-catalog-details.feature

A11y check
Before:

After:

Cypress notes
This issue was noticed while debugging #9361. This fix focused on this cypress issue:

After fixing this the tests still has some issues which are already addressed in #9361.

Browser conformance:

• Chrome
• Firefox
• Safari
• Edge

[jerolimov]

This is the only line we really need for this fix 🤣

[spadgett]

@jerolimov Do you mind opening a Bugzilla bug so we can backport this fix?

[spadgett]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jerolimov, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• frontend/packages/operator-lifecycle-manager/OWNERS [jerolimov,spadgett]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@jerolimov: All pull requests linked via external trackers have merged:

Bugzilla bug 1982153 has been moved to the MODIFIED state.

In response to this:

Bug 1982153: Skip empty categories (id and label) in OperatorHub tab view

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jerolimov]

/bugzilla refresh

[openshift-ci]

@jerolimov: Bugzilla bug 1982153 is in an unrecognized state (MODIFIED) and will not be moved to the MODIFIED state.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jerolimov]

@jerolimov Do you mind opening a Bugzilla bug so we can backport this fix?

@spadgett I created a BZ ticket in management console (https://bugzilla.redhat.com/show_bug.cgi?id=1982153), and marked it as low-prio and low-severity because it doesn't break anything. Feel free to change.

It happen since 4.6, but with this low prio, back to which version do you want a backport? I will add a cherrypick then whenever one version is merged.

[spadgett]

I think just backporting to 4.8 is reasonable.

/cherry-pick release-4.8

[openshift-cherrypick-robot]

@spadgett: new pull request created: #9509

In response to this:

I think just backporting to 4.8 is reasonable.

/cherry-pick release-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.