Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ODC-5581 - Topology Filter Bar - Display Options Automation #9482

Conversation

gajanan-more
Copy link
Contributor

Fix: https://issues.redhat.com/browse/ODC-5581

Problem: Automation to check and validate actions of display options on the Topology Page

Solution: This script will check and validate actions of display options on the Topology Page

Test Setup:

  1. Run yarn run test-cypress-topology in frontend
  2. Execute feature file: frontend/packages/topology/integration-tests/features/topology/topology-filter-bar-display.feature

Test Execution Screenshot:
Screenshot 2021-07-13 at 7 03 53 PM

@openshift-ci openshift-ci bot added component/dev-console Related to dev-console component/topology Related to topology labels Jul 13, 2021
@gajanan-more
Copy link
Contributor Author

/assign @makambalaji @sanketpathak

@sanketpathak
Copy link
Contributor

Tests are working fine
Screenshot from 2021-07-15 15-57-40
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 15, 2021
@gajanan-more gajanan-more force-pushed the ODC-5581-workloads-grouping-automation branch from 4eeee88 to df5e1c4 Compare July 15, 2021 12:39
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 15, 2021
@sanketpathak
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 15, 2021
Copy link
Contributor

@makambalaji makambalaji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes are there, can you please update them

@gajanan-more gajanan-more force-pushed the ODC-5581-workloads-grouping-automation branch from df5e1c4 to 2eb3b59 Compare July 15, 2021 13:10
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 15, 2021
@makambalaji
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 15, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 15, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gajanan-more, makambalaji, sanketpathak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 15, 2021
@openshift-merge-robot openshift-merge-robot merged commit f752e87 into openshift:master Jul 15, 2021
@spadgett spadgett added this to the v4.9 milestone Aug 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/dev-console Related to dev-console component/topology Related to topology lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants