Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ODC-6147-updating cypress.sh and frontend/package.json files #9490

Merged
merged 1 commit into from Jul 15, 2021
Merged

ODC-6147-updating cypress.sh and frontend/package.json files #9490

merged 1 commit into from Jul 15, 2021

Conversation

makambalaji
Copy link
Contributor

@makambalaji makambalaji commented Jul 13, 2021

Description:
While creating pr to execute the scripts w.r.to cron jobs, There are some issues. to fix them, raising this pr

What's changed in this PR
modified the "devconsole" keyword to "dev-console" in frontend/package.json and cypress.sh

Executed below commands to verify

export NO_HEADLESS=true && export CHROME_VERSION=$(/usr/bin/google-chrome-stable --version)
BRIDGE_KUBEADMIN_PASSWORD=i2KzL-3sMve-FmJjz-TC8IB
BRIDGE_BASE_ADDRESS=https://console-openshift-console.apps.rhamilto.devcluster.openshift.com/
export BRIDGE_KUBEADMIN_PASSWORD
echo $BRIDGE_KUBEADMIN_PASSWORD
export BRIDGE_BASE_ADDRESS
export BRIDGE_API
oc login -u kubeadmin -p $BRIDGE_KUBEADMIN_PASSWORD https://api.rhamilto.devcluster.openshift.com:6443/ --insecure-skip-tls-verify
oc apply -f ./frontend/integration-tests/data/htpasswd-secret.yaml
oc patch oauths cluster --patch "$(cat ./frontend/integration-tests/data/patch-htpasswd.yaml)" --type=merge
./test-cypress.sh -p dev-console -h true

Results
image

Copy link
Contributor

@gajanan-more gajanan-more left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 14, 2021
Copy link
Member

@rhamilto rhamilto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 14, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gajanan-more, makambalaji, rhamilto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 14, 2021
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 0d3edef into openshift:master Jul 15, 2021
@spadgett spadgett added this to the v4.9 milestone Aug 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants