Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a11y file input form issue, for example when creating a Secret #9500

Merged
merged 1 commit into from Jul 15, 2021

Conversation

jerolimov
Copy link
Member

Fixes:
https://issues.redhat.com/browse/ODC-6151

Analysis / Root cause:
When running some of the cypress E2E tests the import page fails with some accessibility errors.

Solution Description:
Fix a11y issues:

  • Do not link to an aria-describedby element when no help text is defined.
  • Add "Filename" label to the readonly field which shows the filename.

Screen shots / Gifs for design review:
UI doesn't have changed. Only a11y attributes are changed.

image

Before:
before-1
before-2
before-3

After:
after

Unit test coverage report:
Unchanged.

Test setup:

  1. Open developer perspective > Add > Import from container image
  2. Check accessibility errors with Firefox axe - Web Accessibility Testing extension

Browser conformance:

  • Chrome
  • Firefox
  • Safari
  • Edge

@openshift-ci openshift-ci bot requested review from jcaianirh and kyoto July 14, 2021 10:57
@openshift-ci openshift-ci bot added component/core Related to console core functionality kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 14, 2021
@jerolimov
Copy link
Member Author

/cc @nemesis09

@openshift-ci openshift-ci bot requested a review from nemesis09 July 14, 2021 13:53
@nemesis09
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 14, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 14, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jerolimov, nemesis09

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 9e51260 into openshift:master Jul 15, 2021
@spadgett spadgett added this to the v4.9 milestone Aug 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants