Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CNV-11794: Switch UI internal implementation to use SC profile resources instead of SC config map #9529

Merged
merged 1 commit into from Jul 20, 2021

Conversation

avivtur
Copy link
Contributor

@avivtur avivtur commented Jul 15, 2021

Fixes:
https://issues.redhat.com/browse/CNV-11794

Analysis / Root cause:
Using configMap for optimized setting for StorageClass

Solution Description:
Using StorageProfile Resource and take default optimized setting if existing, if not choosing by the user. also allowing the user to adjust manully the optimized settings

Screen shots / Gifs for design review:

before:
cnv11794-before

after:
cnv11794

Signed-off-by: Aviv Turgeman aturgema@redhat.com

@openshift-ci openshift-ci bot requested review from glekner and yaacov July 15, 2021 17:41
@openshift-ci openshift-ci bot added the component/kubevirt Related to kubevirt-plugin label Jul 15, 2021
@avivtur
Copy link
Contributor Author

avivtur commented Jul 18, 2021

/retest

…ces instead of SC config map

Signed-off-by: Aviv Turgeman <aturgema@redhat.com>
@openshift-ci openshift-ci bot added the kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated label Jul 18, 2021
@yaacov
Copy link
Member

yaacov commented Jul 19, 2021

/retest

@yaacov
Copy link
Member

yaacov commented Jul 19, 2021

/retest
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 19, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 19, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: avivtur, yaacov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 19, 2021
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

6 similar comments
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 7044928 into openshift:master Jul 20, 2021
@spadgett spadgett added this to the v4.9 milestone Jul 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/kubevirt Related to kubevirt-plugin kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants