Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1976072: Ensure supported x-descriptors take priority in Operand details view #9530

Merged
merged 1 commit into from Aug 10, 2021

Conversation

TheRealJon
Copy link
Member

Add sort order to OLM x-descriptors so that descriptors that are supported on the details page will always be used before those that are not.

@openshift-ci openshift-ci bot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Jul 15, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 15, 2021

@TheRealJon: This pull request references Bugzilla bug 1976072, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.9.0) matches configured target release for branch (4.9.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @yapei

In response to this:

Bug 1976072: Ensure supported details view x-descriptors take priority in Operand details view

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from yapei July 15, 2021 17:52
@openshift-ci openshift-ci bot added the component/olm Related to OLM label Jul 15, 2021
@openshift-ci openshift-ci bot requested review from rhamilto and spadgett July 15, 2021 17:52
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 15, 2021
@TheRealJon TheRealJon changed the title Bug 1976072: Ensure supported details view x-descriptors take priority in Operand details view Bug 1976072: Ensure supported x-descriptors take priority in Operand details view Jul 21, 2021
@TheRealJon TheRealJon force-pushed the 1976072 branch 2 times, most recently from c7106b4 to 8c99545 Compare July 26, 2021 14:16
…y in Operand details view

Add sort order to OLM x-descriptors so that descriptors that are supported on the details page will always be used before those that are not.
@TheRealJon
Copy link
Member Author

/retest

Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 10, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 10, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: spadgett, TheRealJon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot merged commit 5496f0d into openshift:master Aug 10, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 10, 2021

@TheRealJon: An error was encountered searching for external tracker bugs for bug 1976072 on the Bugzilla server at https://bugzilla.redhat.com. No known errors were detected, please see the full error message for details.

Full error message. could not unmarshal response body: invalid character '<' looking for beginning of value

Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.

In response to this:

Bug 1976072: Ensure supported x-descriptors take priority in Operand details view

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 10, 2021

@spadgett: Bugzilla bug 1976072 is in an unrecognized state (MODIFIED) and will not be moved to the MODIFIED state.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

TheRealJon added a commit to TheRealJon/console that referenced this pull request Aug 23, 2021
…ction

Revert a change from openshift#9530 that unintentionally made descriptor compatibility more restricted than necessary.
@spadgett spadgett added this to the v4.9 milestone Aug 30, 2021
christianvogt pushed a commit to christianvogt/console that referenced this pull request Sep 20, 2021
…ction

Revert a change from openshift#9530 that unintentionally made descriptor compatibility more restricted than necessary.
@TheRealJon TheRealJon deleted the 1976072 branch January 27, 2022 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/olm Related to OLM lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants